On Thu, Jul 4, 2013 at 2:22 AM, Christian Zigotzky <chzigot...@xenosoft.de> wrote: > Am 04.07.13 03:46, schrieb Vincent Cheng: > >> On Wed, Jul 3, 2013 at 1:42 PM, Christian Zigotzky >> <chzigot...@bayern-mail.de> wrote: >>> >>> Hi Vincent, >>> >>> The issue with the wrong colors has been solved. :) >>> >>> Please insert the following line into file COpenGLExtensionHandler.cpp, >>> line >>> 372 (directly before MultiTextureExtension = >>> FeatureAvailable[IRR_ARB_multitexture] ;) >>> >>> FeatureAvailable[IRR_ARB_vertex_array_bgra]=FeatureAvailable[IRR_EXT_vertex_array_bgra]=false; >>> >> Is it safe to change this for all platforms, i.e. will this cause any >> rendering issues on non-ppc and/or little endian systems? Does >> upstream endorse making this change permanent, e.g. link to upstream >> svn commit please? >> >> Regards, >> Vincent >> >> > Hi Vincent, > > This patch is only for ppc systems. It isn't suitable for other systems like > x86, ARM etc.
The reason I ask whether this is suitable for non-ppc systems is that if I apply your patch in Debian/Ubuntu stk source package, that will affect all binary packages built from that source, including on non-ppc archs (there's no way for me to upload a ppc-specific source package and/or have this patch applied _only_ on ppc). Although I suppose I can just wrap the additional line of code that fixes this bug on ppc with an #ifdef __powerpc__ statement? > I'm very happy about this patch. STK 0.8 works as well as the x86 version of > STK 0.8. > I have released a static package of STK 0.8 with AltiVec support and > integrated Irrlicht patch: > > http://sourceforge.net/projects/supertuxkart/files/SuperTuxKart/0.8/supertuxkart-0.8-altivec-linux-glibc2.13-ppc.tar.bz2/download > > The Irrlicht patch is an unofficial patch for ppc systems at time. > Unfortunately there isn't a link to a upstream svn commit. I'm sorry. Can you please push upstream to include this patch in their svn repo? I'd feel a lot more comfortable applying it in Debian if I knew for certain that upstream approves of it, and that it's going to be included in future releases so I don't have to maintain that patch any longer than necessary. I'll readily admit that I don't know anything about opengl and/or irrlicht, hence why I'm a bit averse to including this patch without upstream's approval. Regards, Vincent -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org