2013/8/11 Ritesh Raj Sarraf <r...@researchut.com> > > On Sunday 11 August 2013 05:37 PM, Eddy Petrișor wrote: > > The fix in the repo still has the original problem, because if the > > /etc/laptop-mode/conf.d or /etc/laptop-mode/conf.d/board-specific > > directories exists, but contains no .conf files, the script will > > generate the ugly warning initially reported since the shell does not > > expand the wildcard. > > I am not able to determine why the current fix will fail. Please see > below testcase. >
You failed to reproduce the else branch in your test. The attached test script displays the issue: heidi:/home/eddy/usr/src/bugs/673818# mkdir /etc/laptop-mode/conf.d/board-specific heidi:/home/eddy/usr/src/bugs/673818# ls /etc/laptop-mode/conf.d/board-specific heidi:/home/eddy/usr/src/bugs/673818# ./test expansion MSG Warning: Configuration file /etc/laptop-mode/conf.d/board-specific/*.conf is not readable, skipping. using ls It is basically the same issue as reported in the bug. -- Regards, EddyP ============================================= The universe is not required to be in perfect harmony with human ambition. - Carl Sagan
test
Description: Binary data
