Package: lintian
Version: 2.5.15
Severity: normal
Tags: patch
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Dear Maintainer,
In bug #708551, a warning was introduced for PEAR packages not using
${phppear:description} and ${phppear:summary}. On some PEAR packages,
the provided description are poor (starting with the package name for
example). Therefore, the use of those macros should not be done blindly.
I propose this patch to
1. downgrade to wishlist the warning
2. explain to not blindly rely on PEAR package descriptions
- -- System Information:
Debian Release: jessie/sid
APT prefers unstable
APT policy: (500, 'unstable'), (500, 'stable'), (101, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 3.10-2-amd64 (SMP w/4 CPU cores)
Locale: LANG=fr_FR.utf8, LC_CTYPE=fr_FR.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Versions of packages lintian depends on:
ii binutils 2.23.52.20130727-1
ii bzip2 1.0.6-5
ii diffstat 1.55-3
ii file 1:5.14-2
ii gettext 0.18.3-1
ii hardening-includes 2.3
ii intltool-debian 0.35.0+20060710.1
ii libapt-pkg-perl 0.1.29
ii libarchive-zip-perl 1.30-7
ii libclass-accessor-perl 0.34-1
ii libclone-perl 0.34-1
ii libdpkg-perl 1.17.1
ii libemail-valid-perl 0.190-1
ii libfile-basedir-perl 0.03-1
ii libipc-run-perl 0.92-1
ii liblist-moreutils-perl 0.33-1+b1
ii libparse-debianchangelog-perl 1.2.0-1
ii libtext-levenshtein-perl 0.06~01-2
ii libtimedate-perl 1.2000-1
ii liburi-perl 1.60-1
ii man-db 2.6.5-2
ii patchutils 0.3.2-2
ii perl [libdigest-sha-perl] 5.14.2-21
ii t1utils 1.37-2
Versions of packages lintian recommends:
ii libautodie-perl 2.20-1
ii libperlio-gzip-perl 0.18-1+b2
ii perl-modules [libautodie-perl] 5.14.2-21
Versions of packages lintian suggests:
pn binutils-multiarch <none>
ii dpkg-dev 1.17.1
ii libhtml-parser-perl 3.71-1
ii libtext-template-perl 1.45-2
ii xz-utils 5.1.1alpha+20120614-2
- -- no debconf information
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.14 (GNU/Linux)
iQIcBAEBCAAGBQJSDLN9AAoJEJWkL+g1NSX5F98P/iu1RN7+v8spPGv3qEqwyOvL
lW3oQfL0Z1rbh0/YOkW+NxXR2+s0Rfow2m1sSH1+5Pk8xS6yXHCEaILhiV8+/fDo
/Hnbx3aLprXEMwliy02xRVM695tXKn4oQz4daDPhhsj5jSPKqhl0BhfvDmBGdO0C
F8zghhK/a7/LdgKTZwXXn/mHI76ofXbROUGPgpMuZtQzkn0I3IQSjxp1jRVKq75U
2fd4BxJEPP70SQZeSGVWD+hW77ifx0C5HH+Pqal40nXjbJrjx0MhoPj8YzFBLx1X
WDqvw1WAp4g53kp/OZhJ/YEeAjZwWUw88vUoxts1PbFs+1Rnnfa+pnJGfMWOJzx+
jei5jM8ctJOjZMndClXxh2qMhKPg+oq9PBFxmO+z/3A+uY/eGtxPrikFd4p84sBB
XqIzX+xzQ8wUL1exGc3K6rq6JYsXJbHMRQ8Fqo5vAF0iz0+FjDeTbC0/rGSGYuby
1QKhSQ2oEggYyk2YlEwCHVrXqmaUQ8GoMXKQM7Er7YZJkkezZXkCaNy4rlWOIBiM
P3d6Gome7uXS3bSOn39ftz2QpDlasurZeQbJvTPXQEST+YHkUw3xe1xA+QIP+3k7
RvaIHO/AKjDVFDbyhgVFO/qbgEy9NqX9+yrisreWc3gQlfUmYXKdDrsfnifD8Hfj
yiYhC0IwDqvTnPR61iaD
=cVDe
-----END PGP SIGNATURE-----
>From 9ca0a9d4ec009d5fb41ffda7678cf5de5780bdd6 Mon Sep 17 00:00:00 2001
From: Vincent Bernat <ber...@luffy.cx>
Date: Thu, 15 Aug 2013 11:50:17 +0200
Subject: [PATCH] Downgrade check for ${phppear:description} and
${phppear:summary}
The check is downgraded to wishlist and the description is enhanced to
explain when the provided description can be used. A reference to
Debian packaging best practices is also used.
---
checks/phppear.desc | 7 ++++++-
t/tests/phppear-pear/tags | 4 ++--
2 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/checks/phppear.desc b/checks/phppear.desc
index b63127f..08b61d0 100644
--- a/checks/phppear.desc
+++ b/checks/phppear.desc
@@ -31,10 +31,15 @@ Info: The package is a PEAR package but its control file doesn't have
${phppear:Debian-Depends} in Depends or ${phppear:Debian-Recommends}.
Tag: pear-package-not-using-substvar
-Severity: normal
+Severity: wishlist
Certainty: possible
Info: The package is a PEAR package but its control file doesn't have
${phppear:summary} or ${phppear:description} in its description fields.
+ .
+ Those substitution variables should only be used if the description
+ included in PEAR package is of sufficient quality and respect Debian
+ packaging best practices.
+Ref: http://www.debian.org/doc/manuals/developers-reference/best-pkging-practices.html#bpp-desc-basics
Tag: pear-package-feature-requires-newer-pkg-php-tools
Severity: normal
diff --git a/t/tests/phppear-pear/tags b/t/tests/phppear-pear/tags
index b819015..e01731b 100644
--- a/t/tests/phppear-pear/tags
+++ b/t/tests/phppear-pear/tags
@@ -1,3 +1,5 @@
+I: phppear-pear source: pear-package-not-using-substvar ${phppear:description}
+I: phppear-pear source: pear-package-not-using-substvar ${phppear:summary}
W: phppear-pear source: missing-pkg-php-tools-addon php5
W: phppear-pear source: missing-pkg-php-tools-addon phppear
W: phppear-pear source: missing-pkg-php-tools-buildsystem phppear
@@ -7,7 +9,5 @@ W: phppear-pear source: pear-package-but-missing-dependency Recommends
W: phppear-pear source: pear-package-feature-requires-newer-pkg-php-tools (>= 1.4~) for package2.xml
W: phppear-pear source: pear-package-feature-requires-newer-pkg-php-tools (>= 1.5~) for PECL support
W: phppear-pear source: pear-package-feature-requires-newer-pkg-php-tools (>= 1~) for package name overrides
-W: phppear-pear source: pear-package-not-using-substvar ${phppear:description}
-W: phppear-pear source: pear-package-not-using-substvar ${phppear:summary}
W: phppear-pear source: pecl-package-requires-build-dependency dh-php5
W: phppear-pear source: pecl-package-requires-build-dependency php5-dev
--
1.8.4.rc2
