Control: tag -1 pending Hello,
On Fri, 23 Aug 2013 08:59:29 +0200 Justus Winter <[email protected]> wrote: > I've attached a patch series that fixes ifupdown to work properly on > Debian/Hurd. Thanks a lot, I've been waiting for them :) Your blog is interesting to read, by the way. > The first patch makes ifupdown use inetutils-ifconfig instead of > ifconfig and fixes its use in two cases. Accepted. > The second patch sanitizes the file names of pid files written by > ifupdown and provides the macro %iface_file_name% that provides the > interface name sanitized in a way so that it is safe to use as a file > name fragment. This is motivated by the fact that on the Hurd network > interfaces are made available as files (e. g. /dev/eth0) and so they > can contain slashes. This is where I did some changes. There's already a feature in ifupdown: if you reference a variable as %iface/a/b%, it's value will be substituted with the first 'a' changed to 'b'. I have changed the behaviour so every occurence is replaced, not just the first one. Also, I think using '.' instead of '-' is a bit better, but if you disagree I may change it back :) > The third patch uses the new %iface_file_name% for pid and dhcp lease > file names on the Hurd. I've changed this so we use %iface///.%, and added a test case just to be sure. -- WBR, Andrew
signature.asc
Description: PGP signature
