Hello Vincent, First of all, thank you for reviewing my package:)
2013/9/1 Vincent Bernat <ber...@debian.org> > ❦ 28 août 2013 16:34 CEST, Ho Wan Chan <smartbo...@gmail.com> : > > > Dear mentors, > > > > I am looking for a sponsor for my package "libsass" > > > > * Package name : libsass > > Version : 1.0-1 > > Upstream Author : Hampton Catlin <supp...@moovweb.com> > > * URL : https://github.com/hcatlin/libsass > > * License : Expat > > Section : libs > > > > It builds those binary packages: > > > > libsass-dev - C implementation of a sass compiler -- development > files > > libsass0 - C implementation of a sass compiler > > Hi Chan! > > The priority in debian/control should be "extra" (option does not exist > and optional is for more essential software). > This one is my most skeptical part. Some say that "optional" is actually the most commonly used (and that's from a Debian Developer). Anyways, I will act accordingly. > > In debian/rules, you define DEB_HOST_MULTIARCH variable but don't use > it. You also override dh_auto_configure to reinvoke it as is. > I just can't understand how Multiarch works, even with the documentation. Thank you. > > Try to provide a symbol file, except if it is not possible to unmangle > all names. In this case, add a lintian override mentioning that. > Oh no, I normally do remember to do symbols files. Sorry... > > The library does not seem to be hardened despite the fact that you use > debhelper 9 and the appropriate flags being passed to the compiler and > the linker. hardening-check finds 5 functions that should be > hardened. Let's ignore that for now. > -- > Debian package sponsoring guidelines: > http://vincent.bernat.im/en/debian-package-sponsoring.html I will soon upload a fixed package. Regards, Howard Chan (smartboyhw) Kubuntu Member
