Package: sawfish
Version: 1:1.5.3-2.1+b1
Severity: important
Tags: patch upstream
Thanks, first of all, for maintaining a package of sawfish for Debian, as
I've been a daily sawfish user since January 2000 and I am glad the project
is still active.
I discovered a problem that is present in the wheezy version of sawfish that
appears to be fixed upstream. I suggest perhaps backporting the patch that
fixes it. Details on this problem as discussed on the sawfish list can be
found at:
http://thread.gmane.org/gmane.comp.window-managers.sawfish/9915/focus=9925
and the patch was posted to the list at:
http://news.gmane.org/find-root.php?message_id=%3c87624v8369.fsf%40derry.pan%3e
I've adapted that patch against the current wheezy source package, and I've
attached it. I hope you'll consider putting it in as a critical bug fix for
sawfish in wheezy, since iceweasel is more-or-less unusable under sawfish
without this patch.
The thread discusses the problem was in sawfish 1.9.1, so I am somewhat
surprised to discover it all the way back to 1.5.3, but I suspect the problem
is related to something new-ish that iceweasel/xulrunner does now with regard
to WM_SIZE_HINTS that iceweasel/xulrunner did not previously do, thus the
problem was not uncovered by most X clients in the past.
The problem exhibits itself when you have xulrunner and/or iceweasel window
on wheezy, and the size of the window becomes very tiny. Attempts to resize
the window using normal means of interactive resizing (i.e., methods other
than sawfish-client scripting) cannot get the window back to a reasonable
size. Sometimes, the problem persists across logging out and back in,
because presumably iceweasel saves some data about its previous window
sizing.
I'm now running my own install if sawfish out of Sawfish's Git repository, so
the latest/greatest doesn't have this problem, but backporting the patch
should work.
The patch is from upstream sources:
commit 798c6992cc41f5ca7ec1bd4bd74d721a59820897
Author: Christopher Roy Bratusek <[email protected]>
Date: 2012-11-26 19:24:25 +0100
which can be seen at:
http://git.tuxfamily.org/sawfish/main.git?p=sawfish/main.git;a=commit;h=798c6992cc41f5ca7ec1bd4bd74d721a59820897
so I believe it's licensed GPLv2-or-later.
FWIW, here's a bug about this problem from Ubuntu:
https://bugs.launchpad.net/ubuntu/+source/sawfish/+bug/1083260
And Gentoo appears to also carry this patch:
http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/x11-wm/sawfish/files/sawfish-1.9.1-firefox.patch?view=markup
-- System Information:
Debian Release: 7.1
APT prefers stable-updates
APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: amd64 (x86_64)
Kernel: Linux 3.2.0-4-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Versions of packages sawfish depends on:
ii gnome-terminal [x-terminal-emulator] 3.4.1.1-2
ii libatk1.0-0 2.4.0-2
ii libaudiofile1 0.3.4-2
ii libc6 2.13-38
ii libcairo2 1.12.2-3
ii libesd0 0.2.41-10+b1
ii libfontconfig1 2.9.0-7.1
ii libfreetype6 2.4.9-1.1
ii libgdk-pixbuf2.0-0 2.26.1-1
ii libglib2.0-0 2.33.12+really2.32.4-5
ii libgmp10 2:5.0.5+dfsg-2
ii libgtk2.0-0 2.24.10-2
ii libice6 2:1.0.8-2
ii libpango1.0-0 1.30.0-1
ii librep9 0.90.2-1.3
ii libsm6 2:1.2.1-2
ii libx11-6 2:1.5.0-1+deb7u1
ii libxext6 2:1.3.1-2+deb7u1
ii libxft2 2.3.1-1
ii libxinerama1 2:1.1.2-1+deb7u1
ii libxrandr2 2:1.3.2-2+deb7u1
ii libxrender1 1:0.9.7-1+deb7u1
ii rep 0.90.2-1.3
ii rep-gtk 1:0.90.0-2
ii sawfish-data 1:1.5.3-2.1
ii xterm [x-terminal-emulator] 278-4
sawfish recommends no packages.
Versions of packages sawfish suggests:
ii gnome-control-center 1:3.4.3.1-2
ii menu 2.1.46
ii yelp 3.4.2-1+b1
-- debconf-show failed
--- sawfish-1.5.3/src/windows.c.~1~ 2009-11-12 15:02:10.000000000 -0500
+++ sawfish-1.5.3/src/windows.c 2013-09-02 13:05:42.160435706 -0400
@@ -1286,6 +1286,13 @@
hints = &VWIN(win)->hints;
flags = hints->flags;
+ /* workaround stuff like Firefox 17 that
+ * has enormous max-width/maxh-height */
+ if (hints->max_width >= 32767)
+ hints->max_width = 32767;
+ if (hints->max_height >= 32767)
+ hints->max_height = 32767;
+
/* Some sanity checking */
if ((flags & PMinSize)
&& (hints->min_width < 0 || hints->min_height < 0))
