Package: dictionaries-common
Version: 1.20.2
Severity: wishlist

Here are some improvement suggestions to the Emacs startup
configuration:

    * Patch 1: No need to load at the very start of Emacs start up.
      Make setup load, when the ispell is actuallu used/loaded. This
      helps to make Emacs faster at start when additional settings
      are postponed.

    * Patch 2: Do not display any extra messages on echo-area. The
      information "...already loaded" may confuse new users.

    * Patch 3: In order to check debian-ispell.el locally, this fails:

      emacs -Q -q -ne debian-ispell.el
      M-x eval-current-buffer

      The patch adds "fboundp" check for appropriate place and makes
      the above commands to work.

Jari

-- System Information:
Debian Release: jessie/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 3.2.0-4-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_DK.UTF-8, LC_CTYPE=en_DK.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages dictionaries-common depends on:
ii  debconf [debconf-2.0]  1.5.50
ii  libtext-iconv-perl     1.7-5

dictionaries-common recommends no packages.

Versions of packages dictionaries-common suggests:
ii  emacsen-common  2.0.5
ii  ispell          3.3.02-6
pn  jed-extra       <none>

-- debconf-show failed
>From 21a97f670d8a2e30f5ad9ed93e6fb973dc8a80a7 Mon Sep 17 00:00:00 2001
From: Jari Aalto <[email protected]>
Date: Wed, 4 Sep 2013 09:36:20 +0300
Subject: [PATCH 2/3] In debian-ispell.el Do not display extra messages at
 debian-ispell-set-startup-menu
Organization: Private
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

Signed-off-by: Jari Aalto <[email protected]>
---
 support/emacsen/debian-ispell.el |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/support/emacsen/debian-ispell.el b/support/emacsen/debian-ispell.el
index b5e9a59..41e74e1 100644
--- a/support/emacsen/debian-ispell.el
+++ b/support/emacsen/debian-ispell.el
@@ -244,7 +244,7 @@ To be run at `after-init-hook' or at any time if FORCE is given."
 
     (if (and (featurep 'ispell)
 	     (not force))
-	(message "ispell.el is already loaded")
+	nil
       (when (fboundp 'debian-ispell-build-startup-menu)
 	(debian-ispell-build-startup-menu dicts-list)
 	;; (fmakunbound 'debian-ispell-build-startup-menu)
-- 
1.7.10.4

>From f59851fb956642e0a43e296fb04bfab5577ae534 Mon Sep 17 00:00:00 2001
From: Jari Aalto <[email protected]>
Date: Wed, 4 Sep 2013 09:35:22 +0300
Subject: [PATCH 1/3] In debian-ispell.el load setup after ispell, not at
 Emacs start up
Organization: Private
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

Signed-off-by: Jari Aalto <[email protected]>
---
 support/emacsen/debian-ispell.el |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/support/emacsen/debian-ispell.el b/support/emacsen/debian-ispell.el
index 4a57a0b..b5e9a59 100644
--- a/support/emacsen/debian-ispell.el
+++ b/support/emacsen/debian-ispell.el
@@ -251,10 +251,10 @@ To be run at `after-init-hook' or at any time if FORCE is given."
 	))))
 
 ;; Make sure updated Debian menu is available after emacs is started
-(add-hook 'after-init-hook 'debian-ispell-set-startup-menu)
+;; (add-hook 'after-init-hook 'debian-ispell-set-startup-menu)
 
 ;; Make sure updated Debian menu is not overriden by ispell.el one
-(eval-after-load "ispell" '(debian-ispell-set-startup-menu))
+(eval-after-load "ispell" '(debian-ispell-set-startup-menu 'force))
 
 ;;; -----------------------------------------------------------------------
 ;;;  Guess default ispell dictionary under emacs and make ispell.el use it
-- 
1.7.10.4

>From 3a4d8bba3ffd8a4c1e5a7c7318b49a1b68973dcb Mon Sep 17 00:00:00 2001
From: Jari Aalto <[email protected]>
Date: Wed, 4 Sep 2013 09:38:11 +0300
Subject: [PATCH 3/3] In debian-ispell.el Check debian-pkg-add-load-path-item
 before use
Organization: Private
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

Signed-off-by: Jari Aalto <[email protected]>
---
 support/emacsen/debian-ispell.el |   14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/support/emacsen/debian-ispell.el b/support/emacsen/debian-ispell.el
index 41e74e1..c9c2c18 100644
--- a/support/emacsen/debian-ispell.el
+++ b/support/emacsen/debian-ispell.el
@@ -458,17 +458,19 @@ LANG if any."
 		 ispell-program-name))
     )) ;; let and defun ends
 
-(add-hook 'after-init-hook 'debian-ispell-set-default-dictionary)
+;; (add-hook 'after-init-hook 'debian-ispell-set-default-dictionary)
+(eval-after-load "ispell" '(debian-ispell-set-default-dictionary))
 
 ;; ---------------------------------------------------------------------------
 ;; Make sure patched ispell.el is first in the loadpath if not already there
 ;; ---------------------------------------------------------------------------
 
-(let ((mypath (concat "/usr/share/"
-		      (symbol-name debian-emacs-flavor)
-		      "/site-lisp/dictionaries-common")))
-  (unless (member mypath load-path)
-    (debian-pkg-add-load-path-item mypath)))
+(when (fboundp 'debian-pkg-add-load-path-item)
+  (let ((mypath (concat "/usr/share/"
+			(symbol-name debian-emacs-flavor)
+			"/site-lisp/dictionaries-common")))
+    (unless (member mypath load-path)
+      (debian-pkg-add-load-path-item mypath))))
 
 ;; --------------------------------------------------------------------------
 ;; Set ispell-program-name consistently for all emacsen flavours. Prefer
-- 
1.7.10.4

Reply via email to