Package: aria2 Version: 1.18.0-1 Tags: patch User: [email protected] Usertags: origin-ubuntu ubuntu-patch trusty
Hello, thanks for adding an autopkgtest! However, this currently assumes that it can reach http://www.debian.org/, which may not always be the case in test environments. It would be better to run it against a local HTTP server, which also makes it easier/possible to actually verify the result. As a proposal I attach a debdiff which I just uploaded to Ubuntu. It uses "python3 -m http.server" (which is the simplest, least intrusive, and easiest server which I'm aware of) and compares the downloaded file against the original one. Thanks for considering, Martin -- Martin Pitt | http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org)
diff -Nru aria2-1.18.0/debian/changelog aria2-1.18.0/debian/changelog --- aria2-1.18.0/debian/changelog 2013-09-22 19:15:53.000000000 +0200 +++ aria2-1.18.0/debian/changelog 2013-10-24 08:19:12.000000000 +0200 @@ -1,3 +1,10 @@ +aria2 (1.18.0-1ubuntu1) trusty; urgency=low + + * debian/tests/httpfile: Use local http server (with python3 -m http.server) + instead of relying on network access, and verify the downloaded result. + + -- Martin Pitt <[email protected]> Thu, 24 Oct 2013 08:18:45 +0200 + aria2 (1.18.0-1) unstable; urgency=low [ Kartik Mistry ] diff -Nru aria2-1.18.0/debian/tests/control aria2-1.18.0/debian/tests/control --- aria2-1.18.0/debian/tests/control 2013-09-22 14:58:28.000000000 +0200 +++ aria2-1.18.0/debian/tests/control 2013-10-24 08:11:14.000000000 +0200 @@ -1 +1,2 @@ Tests: httpfile +Depends: @, python3 diff -Nru aria2-1.18.0/debian/tests/httpfile aria2-1.18.0/debian/tests/httpfile --- aria2-1.18.0/debian/tests/httpfile 2013-09-22 14:58:28.000000000 +0200 +++ aria2-1.18.0/debian/tests/httpfile 2013-10-24 08:18:28.000000000 +0200 @@ -1 +1,14 @@ -aria2c -d /tmp http://www.debian.org +#!/bin/sh +set -e +PORT=43248 + +# start local http server +cd /etc +python3 -m http.server $PORT & +HTTP_PID=$! +trap "kill $HTTP_PID" EXIT TERM INT + +aria2c -d $ADTTMP http://localhost:$PORT/passwd + +# verify that files are identical +cmp /etc/passwd $ADTTMP/passwd
signature.asc
Description: Digital signature
