Hi >on Monday 28 October 2013-13:09:24 Guido Günther (Guido Günther <a...@sigxcpu.org>) wrote: > Hi Manuel,, > > On Mon, Oct 28, 2013 at 10:30:50AM +0100, Manuel VIVES wrote: > > Hi Guido > > [..snip..] > > > I agree with you for moving it into libvirt-bin, so I did it and I > > modified the libvirt-bin script in order to do this. > > It is attached to the mail. > > I also made a check for systemd, and if it's running, there is just a > > message saying that you can not use this cgroup configuration with > > systemd and the function exits. > > Great! The systemd_running funciton seems to check for the wrong dir > though ;) Moreover: shouldn't we better execute mount_cgroups when the > daemon gets started (iff system_like_cgroups is set in > /etc/default/libvirt-bin) and try to unmount it on daemon stop (we > shouldn't fail then since there might be other cgroups running). > > Having them as extra targets is nice but wouln't work by itself if we want > to do it automatically on system startup. Here is the new version, so the folder tested is changed ;) There is also a function called "check_mount_cgroup_options" which checks if the variable "mount_cgroups_at_startup" is yes, and if so, it will mount cgroups when starting the daemon, but it will also umount cgroups when stopping it. If the mount fails we exit, but we don't if it's the umount that fails.
Regards, Manuel VIVES > Cheers, > -- Guido
libvirt-bin
Description: application/shellscript
