Hi gregor!

El dc 30 de 10 de 2013 a les 23:25 +0100, en/na gregor herrmann va
escriure: 
> Package: dianara
> Version: 0.9-1
> Severity: minor
> Tags: patch upstream
> 
> Hi Mònica!
> 
> I was missing a keyboard shortcut for quitting dianara; the Session
> menu only shows Quit without any hint, trying several obvious
> combinations also didn't work.
> 
> The interesting thing is that there should be something, according to
> the code: src/mainwindow.cpp has
>     sessionQuit->setShortcut(QKeySequence::Quit);
> but this doesn't work at least in my environment [0], or I don't know how
> it should work :)
> 
> And the Qt documentation [1] is also not so helpful, it mentions Ctrl-Q
> for KDE and Gnome; and for the rest?
> 
> So I'm using the following patch to get Ctrl-Q working:
> 
> #v+
> --- a/src/mainwindow.cpp
> +++ b/src/mainwindow.cpp
> @@ -629,7 +629,7 @@ void MainWindow::createMenus()
>  
>      sessionQuit = new QAction(QIcon::fromTheme("application-exit"),
>                                tr("&Quit"), this);
> -    sessionQuit->setShortcut(QKeySequence::Quit);
> +    sessionQuit->setShortcut(QKeySequence("Ctrl+Q"));
>      connect(sessionQuit, SIGNAL(triggered()),
>              this, SLOT(quitProgram()));
>      sessionMenu->addAction(sessionQuit);
> #v-

Yes, I tested this issue in an awesome environment and I can reproduce
this bug. Since the change you suggest doesn't affect other
environments, I've applied the patch to the new version of dianara. 

> Maybe you can discuss this with upstream?

Yes, I contacted him explaining this issue. Let's see if he wants to
apply this patch as well :-) 

> Thanks for packaging dianara!

Thanks for reporting bugs!

Cheers,
Mònica

Attachment: signature.asc
Description: This is a digitally signed message part

Reply via email to