Control: severity -1 important

I would like request a different patch than what was initially
suggested. Instead debhelper should set:

diff --git a/Debian/Debhelper/Buildsystem/cmake.pm
b/Debian/Debhelper/Buildsystem/cmake.pm
index 1d009b4..d47821c 100644
--- a/Debian/Debhelper/Buildsystem/cmake.pm
+++ b/Debian/Debhelper/Buildsystem/cmake.pm
@@ -43,6 +43,7 @@ sub configure {
  # Standard set of cmake flags
  push @flags, "-DCMAKE_INSTALL_PREFIX=/usr";
  push @flags, "-DCMAKE_VERBOSE_MAKEFILE=ON";
+ push @flags, "-DCMAKE_BUILD_TYPE=None";

  # CMake doesn't respect CPPFLAGS, see #653916.
  if ($ENV{CPPFLAGS} && ! compat(8)) {


As can be seen in :

http://bugs.debian.org/730636#15
or
http://bugs.debian.org/711515#30

Strictly speaking build system (eg. cmake) should not try to set any
compilation flags themselves. It is required by policy that CFLAGS and
CXXFLAGS (solely) are used when building.

Thanks.


-- 
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]

Reply via email to