Package: dh-golang Version: 1.4 Severity: important Dear Maintainer, Although my system information reported here is from Ubuntu I have reproduced in a sid sbuild as well.
I've pinpointed the problem to http://anonscm.debian.org/gitweb/?p=collab-maint/dh-golang.git;a=blobdiff;f=lib/Debian/Debhelper/Buildsystem/golang.pm;h=9d55e63c0e9ad97a8ab6f43caf4523cfa657ecc0;hp=eb96d85327ebf2ee0dc5a81e1c1fabe388b9bf58;hb=b77530f5d4bebbb094b6dde72632a86a407e1b02;hpb=8cb05ba21120052965102bfe5c92fa626488aa73 A patch is attached -- System Information: Debian Release: wheezy/sid APT prefers trusty-updates APT policy: (500, 'trusty-updates'), (500, 'trusty-security'), (500, 'trusty'), (100, 'trusty-backports') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 3.12.0-7-generic (SMP w/8 CPU cores) Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Versions of packages dh-golang depends on: ii debhelper 9.20131127ubuntu1 ii dpkg 1.17.1ubuntu1 ii libparse-debcontrol-perl 2.005-4 ii perl 5.18.1-4build1 dh-golang recommends no packages. dh-golang suggests no packages. -- no debconf information
From dbbc3d3a5b44ce7a75a91eaf2613fe88c92a29d8 Mon Sep 17 00:00:00 2001 From: Sergio Schvezov <[email protected]> Date: Wed, 11 Dec 2013 23:30:48 -0300 Subject: [PATCH] The loop search for .go files returns incorrectly In the copy part of configure when looping through the sourcefiles and not exporting DH_GOLANG_INSTALL_ALL all the go files are incorrectly skipped. Signed-off-by: Sergio Schvezov <[email protected]> --- lib/Debian/Debhelper/Buildsystem/golang.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/Debian/Debhelper/Buildsystem/golang.pm b/lib/Debian/Debhelper/Buildsystem/golang.pm index 9d55e63..c73c387 100644 --- a/lib/Debian/Debhelper/Buildsystem/golang.pm +++ b/lib/Debian/Debhelper/Buildsystem/golang.pm @@ -65,7 +65,7 @@ sub configure { }, wanted => sub { my $name = $File::Find::name; - return if substr($name, -3) eq '.go' && + return if !substr($name, -3) eq '.go' && (!exists($ENV{DH_GOLANG_INSTALL_ALL}) || $ENV{DH_GOLANG_INSTALL_ALL} != 1); return unless -f $name; -- 1.8.5.1
