Package: dh-python
Version: 1.20131021-2
Severity: important

The dh-python package in Debian has its test suite disabled via
debian/rules, with a 'FIXME' comment.  The reason for this, it appears, is
that t201 is completely broken wrt the actual symlink handling in dh-python.

tests/t201/Makefile includes the following check:

        [ "`readlink 
debian/python-foo/usr/lib/python$(DPY)/dist-packages/foo/absolute_link_to_tmp`" 
= "/tmp" ]
        [ "`readlink 
debian/python-foo/usr/lib/python$(DPY)/dist-packages/foo/link_to_parent_dir`" = 
".." ]

But dh_python2 unconditionally moves symlinks from /usr/lib/python* to
/usr/share/pyshared, replacing them with relative symlinks in the original
directory.

    for package, pdetails in dh.packages.items():
[...]
        if not private_dir:
            share(package, stats, options)d exists(pyshared_dir):

I don't know which of these you consider "correct", but they're obviously
inconsistent, which makes it impossible to use the test suite for the
purpose of detecting regressions in the code.

I'm happy to provide a patch if you can tell me which should be changed, the
code or the test.

Bypassing this check gives me a subsequent failure in tests t202, t204, and
t206 because of hard-coded references to python2.6 that are easily fixed,
and presumably would have been noticed if the testsuite hadn't been disabled
in the package.

-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                    http://www.debian.org/
[email protected]                                     [email protected]

Attachment: signature.asc
Description: Digital signature

Reply via email to