Package: libopenoffice-oodoc-perl
Version: 2.125-2
Tags: patch

The current version of libopenoffice-oodoc-perl in Debian (and in
Ubuntu) has a rather annoying little bug: it seems to spew out
warnings of the form:

  Use of uninitialized value in lc at /usr/share/perl5/OpenOffice/OODoc/File.pm 
line 378.

This is due, of course, to the function "lc" being applied to a
possibly-undefined value.

The solution is to change OODoc/File.pm, line 378, from:

  my $od = lc $self->{'opendocument'};

to:

  my $od = $self->{'opendocument'};
  $od = lc $od if defined($od);

I have prepared a patch against the current Debian package that
creates a new debian/patches/silence-warnings.patch file with the
appropriate diff.

Could you please apply this patch.  Thanks!

Yours truly,

John Zaitseff

-- 
John Zaitseff                    ,--_|\    The ZAP Group
Phone:  +61 2 9643 7737         /      \   Sydney, Australia
E-mail: j.zaits...@zap.org.au   \_,--._*   http://www.zap.org.au/
                                      v
diff -ruNa libopenoffice-oodoc-perl-2.125.orig/debian/patches/series libopenoffice-oodoc-perl-2.125/debian/patches/series
--- libopenoffice-oodoc-perl-2.125.orig/debian/patches/series	2012-05-05 04:54:11.000000000 +1000
+++ libopenoffice-oodoc-perl-2.125/debian/patches/series	2013-12-24 16:05:50.691089499 +1100
@@ -1,2 +1,3 @@
 fix-pod-errors.patch
 spelling.patch
+silence-warnings.patch
diff -ruNa libopenoffice-oodoc-perl-2.125.orig/debian/patches/silence-warnings.patch libopenoffice-oodoc-perl-2.125/debian/patches/silence-warnings.patch
--- libopenoffice-oodoc-perl-2.125.orig/debian/patches/silence-warnings.patch	1970-01-01 10:00:00.000000000 +1000
+++ libopenoffice-oodoc-perl-2.125/debian/patches/silence-warnings.patch	2013-12-24 16:10:05.991918678 +1100
@@ -0,0 +1,14 @@
+Index: libopenoffice-oodoc-perl-2.125/OODoc/File.pm
+===================================================================
+--- libopenoffice-oodoc-perl-2.125.orig/OODoc/File.pm	2010-07-08 03:39:55.000000000 +1000
++++ libopenoffice-oodoc-perl-2.125/OODoc/File.pm	2013-12-24 16:09:54.972228124 +1100
+@@ -375,7 +375,8 @@
+ 		@_
+ 		};
+ 
+-	my $od = lc $self->{'opendocument'};
++	my $od = $self->{'opendocument'};
++	$od = lc $od if defined($od);
+ 	unless ($od)
+ 		{
+ 		if ($OpenOffice::OODoc::File::DEFAULT_OFFICE_FORMAT == 2)

Reply via email to