Package: cvsweb
Version: 3:3.0.6-7
Severity: important
Tags: patch

Hello,

It appears that cvsweb has some issues with Perl 5.18 (5.14 works fine).
Specifically, it errors out with a slew of syntax errors when invoked
from Apache:

[Tue Dec 24 09:57:35.058676 2013] [cgi:error] [pid 17746] [client
10.3.254.229:58703] AH01215: "my" variable $tmp masks earlier
declaration in same statement at /usr/lib/cgi-bin/cvsweb line 1340.
[Tue Dec 24 09:57:35.058741 2013] [cgi:error] [pid 17746] [client
10.3.254.229:58703] AH01215: syntax error at /usr/lib/cgi-bin/cvsweb
line 1197, near "$v qw(hidecvsroot hidenonreadable)"
[Tue Dec 24 09:57:35.058767 2013] [cgi:error] [pid 17746] [client
10.3.254.229:58703] AH01215: Global symbol "$v" requires explicit
package name at /usr/lib/cgi-bin/cvsweb line 1199.
[Tue Dec 24 09:57:35.058792 2013] [cgi:error] [pid 17746] [client
10.3.254.229:58703] AH01215: Global symbol "$v" requires explicit
package name at /usr/lib/cgi-bin/cvsweb line 1199.
[Tue Dec 24 09:57:35.058811 2013] [cgi:error] [pid 17746] [client
10.3.254.229:58703] AH01215: syntax error at /usr/lib/cgi-bin/cvsweb
line 1278, near "}"
[Tue Dec 24 09:57:35.058830 2013] [cgi:error] [pid 17746] [client
10.3.254.229:58703] AH01215: syntax error at /usr/lib/cgi-bin/cvsweb
line 1291, near "}"
[Tue Dec 24 09:57:35.058848 2013] [cgi:error] [pid 17746] [client
10.3.254.229:58703] AH01215: syntax error at /usr/lib/cgi-bin/cvsweb
line 1297, near "}"
[Tue Dec 24 09:57:35.058867 2013] [cgi:error] [pid 17746] [client
10.3.254.229:58703] AH01215: syntax error at /usr/lib/cgi-bin/cvsweb
line 1304, near "}"
[Tue Dec 24 09:57:35.058885 2013] [cgi:error] [pid 17746] [client
10.3.254.229:58703] AH01215: syntax error at /usr/lib/cgi-bin/cvsweb
line 1314, near "}"
[Tue Dec 24 09:57:35.058904 2013] [cgi:error] [pid 17746] [client
10.3.254.229:58703] AH01215: syntax error at /usr/lib/cgi-bin/cvsweb
line 1338, near "}"
[Tue Dec 24 09:57:35.058925 2013] [cgi:error] [pid 17746] [client
10.3.254.229:58703] AH01215: syntax error at /usr/lib/cgi-bin/cvsweb
line 1340, near ""$tmp,v" }"
[Tue Dec 24 09:57:35.058940 2013] [cgi:error] [pid 17746] [client
10.3.254.229:58703] AH01215: /usr/lib/cgi-bin/cvsweb has too many
errors.

As a result, cvsweb produces an HTTP 500 error when accessed from a web
browser.

The NetBSD folks have worked around this by changing two lines in
cvsweb:

http://cvsweb.netbsd.org/bsdweb.cgi/pkgsrc/www/cvsweb/patches/patch-cvsweb.cgi.diff?r1=1.1.2.1&r2=1.1.2.2&f=h

The below patch does the same thing and is based on the version of
cvsweb that is included in the Debian package:

--- cvsweb.orig 2013-12-24 09:58:09.333520125 -0500
+++ cvsweb      2013-12-24 09:58:50.222171067 -0500
@@ -1194,7 +1194,7 @@
 <legend>General options</legend>
 <input type="hidden" name="copt" value="1" />
 EOF
-    for my $v qw(hidecvsroot hidenonreadable) {
+    for my $v (qw(hidecvsroot hidenonreadable)) {
       printf(qq{<input type="hidden" name="%s" value="%s" />\n},
              $v, $input{$v} || 0);
     }
@@ -2953,7 +2953,7 @@
   print "<br />\n";
 
   print '<i>';
-  if (defined @mytz) {
+  if (@mytz) {
     my ($est) = $mytz[(localtime($date{$_}))[8]];
     print scalar localtime($date{$_}), " $est</i> (";
   } else {

Thanks!

- Mark

-- System Information:
Debian Release: jessie/sid
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 3.2.0-4-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages cvsweb depends on:
ii  apache2              2.4.6-3
ii  apache2-bin [httpd]  2.4.6-3
ii  cvs                  2:1.12.13+real-11
ii  libipc-run-perl      0.92-1
ii  libmime-tools-perl   5.503-1
ii  liburi-perl          1.60-1
ii  rcs                  5.9.1-2

cvsweb recommends no packages.

Versions of packages cvsweb suggests:
pn  cvsgraph                      <none>
pn  enscript                      <none>
pn  libmime-types-perl            <none>
ii  perl [libcompress-zlib-perl]  5.18.1-4
ii  zip                           3.0-7

-- no debconf information


-- 
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]

Reply via email to