Hi,

Le 30/12/2013 13:19, Guido Günther a écrit :
On Mon, Dec 30, 2013 at 11:23:57AM +0100, phep wrote:
Hi,

Thank you for packaging libvirt,

Since I just hit the problem this morning while upgrading my laptop,
I tried applying the changes referenced in the subject line.

Alas, as I feared as I read it, the patch does not fix the issue :
"memory" was already in the mount list.

Doh - you're right. I forgot to drop it from the default mount list.
Fixed now.

Thank you for your prompt reply.


One still has to add cgroup_enable=memory on the linux cmd line if
one does not want to be left with an half-configured libvirt-bin (on
jessie, at last).

It's by no means half configured - it just doesn't use mem cgroups.

Actually it is. If one has mount_cgroups=yes in /etc/default/libvirt-bin (and nothing on the kernel cmdline), updating libvirt-bin results in the following :


Paramétrage de libvirt-bin (1.2.0-1) ...
[ ok ] Stopping libvirt management daemon: libvirtd not running.
[....] Starting libvirt management daemon: libvirtdmount: special device cgroup_memory does not exist
[warn] Can not mount cgroups layout ... (warning).
invoke-rc.d: initscript libvirt-bin, action "start" failed.
dpkg: error processing package libvirt-bin (--configure):
le sous-processus script post-installation installé a retourné une erreur de sortie d'état 1
Des erreurs ont été rencontrées pendant l'exécution :
 libvirt-bin
E: Sub-process /usr/bin/dpkg returned an error code (1)
Échec de l'installation d'un paquet. Tentative de réparation :
Paramétrage de libvirt-bin (1.2.0-1) ...
[ ok ] Stopping libvirt management daemon: libvirtd not running.
[....] Starting libvirt management daemon: libvirtdmount: special device cgroup_memory does not exist
[warn] Can not mount cgroups layout ... (warning).
invoke-rc.d: initscript libvirt-bin, action "start" failed.
dpkg: error processing package libvirt-bin (--configure):
le sous-processus script post-installation installé a retourné une erreur de sortie d'état 1
Des erreurs ont été rencontrées pendant l'exécution :
 libvirt-bin
Appuyez sur Entrée pour continuer.

This persists even after one apply your patches.

I'm not well versed in the cgroup machinery, but I don't think that the modifications to the init.d script and /etc/default/libvirt-bin you committed change anything for people who do _not_ have cgroup_enable=memory in the kernel cmdline. As far as I can understand the only difference you introduced with those two patches was to create the mount point and call mount for the memory subsystem if cgroup_enable=memory is on the cmdline, but it does not seem to change anything for those who don't have !

I'll try to investigate this more deeply tonight.

Cheers,

phep


--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to