Control: retitle -1 openguides: uninstallable due to change in www-data's shell
Control: severity -1 grave

On Thu, Jan 09, 2014 at 12:34:40PM +0000, Colin Watson wrote:
> In base-passwd 3.5.30, I changed www-data's shell to /usr/sbin/nologin
> (a change that I really should have made about ten years ago).  This has
> unfortunately had a bit of collateral damage: openguides' wiki-toolkit
> upgrade hook will fail because it tries to use "su www-data" without
> overriding the shell.  Here's a fix:

Sorry, I missed a piece here, and an important one: the similar su call
in the postinst will I think generally render this package
uninstallable.  Here's an updated patch.

  * Pass "-s /bin/sh" to "su www-data" to cope with the change of www-data's
    shell in base-passwd 3.5.30.

diff -Nru openguides-0.74/debian/postinst openguides-0.74/debian/postinst
--- openguides-0.74/debian/postinst     2013-08-27 23:42:47.000000000 +0100
+++ openguides-0.74/debian/postinst     2014-01-09 12:35:49.000000000 +0000
@@ -27,7 +27,7 @@
                echo "Possibly setting up or updating default site database..."
                for file in `ls /etc/openguides/*/wiki.conf`; do
                    echo "Processing config file $file ...";
-                   su -c "/usr/bin/openguides-setup-db $file" www-data;
+                   su -s /bin/sh -c "/usr/bin/openguides-setup-db $file" 
www-data;
                done
                echo "Possibly checking/fixing SQLite file permissions..."
                find /var/lib/openguides/sqlite/ -user root -exec chown 
www-data:www-data {} \;
diff -Nru openguides-0.74/debian/wiki-toolkit-upgrade-hooks/openguides 
openguides-0.74/debian/wiki-toolkit-upgrade-hooks/openguides
--- openguides-0.74/debian/wiki-toolkit-upgrade-hooks/openguides        
2013-08-27 23:42:47.000000000 +0100
+++ openguides-0.74/debian/wiki-toolkit-upgrade-hooks/openguides        
2014-01-09 12:34:06.000000000 +0000
@@ -4,5 +4,5 @@
 
 for file in `ls /etc/openguides/*/wiki.conf`; do
     echo "Processing config file $file ...";
-    su -c "/usr/bin/openguides-setup-db $file" www-data;
+    su -s /bin/sh -c "/usr/bin/openguides-setup-db $file" www-data;
 done

-- 
Colin Watson                                       [[email protected]]


-- 
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]

Reply via email to