Hi Johan, Johan Euphrosine <pro...@google.com> writes: >> Can you please push the forgotten branches/tags? Thanks! > > Done (and tested). Thanks.
A few comments: • You’ll want to bump debian/compat to 9 since you are requiring debhelper >= 9 as build-dependency anyways. • In debian/copyright, I’d recommend to license debian/ under the same license that upstream ships with (i.e. BSD-2-clause in this case). This is to prevent licensing issues when shipping patches in debian/patches • debian/docs is empty, so just delete it? • In debian/README.Source, if you want to make it perfect, add git checkout <revision> to make the instructions easily reproducible. Aside from that: • I’m curious about debian/Dockerfile. What do you use it for? AFAICT, it “just” builds a package automatically. Apart from the step which fetches the current upstream source, you can already do that with gbp-clone and git-buildpackage, right? -- Best regards, Michael -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
