Hi Markus, On Thu, Jan 30, 2014 at 5:19 AM, Markus Koschany <a...@gambaru.de> wrote: > Hi all, > > I think I have finished version 2.4.1 of freeciv. You can find all changes > in Debian's git repository. Please let me know if you would like me to improve > something. Otherwise I suggest to test this version a little and then upload > it > at the weekend, if everything works as intended. > > http://git.debian.org/?p=pkg-games/freeciv.git;a=summary
Looks good; built, signed, and uploaded, thanks for your work! Some minor nitpicks (none of which block upload): - since you're building all the client and data binary packages from the same source package, for the client packages, why not just depend on freeciv-data (= ${source:Version}) instead of your current approach ( freeciv-data (<= ${source:Version}), freeciv-data (>= ${source:Upstream-Version}))? The former approach will work equally well for source uploads and won't break on binNMUs, so I'm unsure what the benefit of using the latter is? - you don't need autotools-dev if you're already using dh-autoreconf (you're invoking both helpers in d/rules) - add-keywords-to-desktop-files.patch doesn't have a proper DEP-3 header (assuming you've forwarded this upstream, it's missing a link to upstream's bug tracker) Jacob, Marko: would it be possible to sign upstream's tarball with a gpg key (rationale can be found at [1])? It's certainly not required or anything, just a suggestion. :) Cheers, Vincent [1] http://lintian.debian.org/tags/debian-watch-may-check-gpg-signature.html -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org