fredagen den 31 januari 2014 23.01.54 skrev du: > I've attached an updated patch solving some of the issues upstream > commented on in the last patch. I have not had time to update all of > it yet, but thought it best to check if it would get accepted into > Debian even if upstream refuse to include it.
I think you've missed a couple of free()s, at least in the various loops in wrapper.c. The final free()s could be moved inside the loops, but the plan was to reuse the already allocated buffer if it's large enough, wasn't it? Using strlcpy after having already ascertained that the buffer is large enough is unnecessary (the existing code used strlcpy, it's not something you added, I know). -- Magnus Holmgren [email protected] Debian Developer
signature.asc
Description: This is a digitally signed message part.
