Ok, I think I progressed a bit on the packaging (even if not done yet). Lintian outputs: W: flare-game: desktop-command-not-in-package usr/share/applications/flare.desktop usr/games/flare W: flare-engine: binary-without-manpage usr/games/flare-engine
And I comment in you email. On Mon, Jan 13, 2014 at 09:31:00PM +0000, Manuel A. Fernandez Montecelo wrote: > Review (maybe some of this is already fixed, I'm reviewing commitdiffs > more than the final files, it's easier for me this way): > > > 1) I think that the "Conflicts" should be a "Breaks, Replaces" Done. > 2) debian/flare.install should be called flare-engine.install, the > binary package I renamed it "install" alone. > 3) I don't think that the executable "flare" should be renamed, if > that's the name upstream uses and doesn't cause conflicts. And this > avoid the patch to cmakelists.txt and flare.sh (which would need an > additional manpage, etc). Well, I'm not sure I agree here, so I didn't do it yet. The think is that users will expect `flare` to start the game as it used to do. I may change my mind overnight, but not sure yet. > 3.1) Maybe only a binary "flare-game" if you want to make it easier > for users, a shell as it is now but without .sh in the name (I think > that it's recommended not have .sh, .py etc in /usr/bin), and with a > simple manpage will do. I don't know what upstream recommend to > launch the games though. Same here. > 4) I think that you leave the game data package named "flare", I think > that "flare-game" is more descriptive and follows upstream names, if > there's no reason for the contrary done. > 5) "flare-engine" binary package should recommend (or suggest?) > "flare-game" with ">= 0.19, <= 0.20"; and the same from the game data > to the engine (but with depends instead of just recommends); because > often (at least in the past) game and data were changed to suit each > other every version I used "flare-game (= 0.19)", as flare-game (>= 0.19, <= 0.20) was raising an error. > 6) I think that .xz (and probably with options -9e) should be used for > orig.tar, especially the data... last time that I checked had very > significant reduction compared to gzip Done, but I'd like to have a debian/rules::get-orig that automatizes that, or I'll forget each time to do so (It went from 170M with gz down to 168M with xz -9e, not such a big deal but anyway). > Sorry for the brevity and the direct style, I had a quite hard day at > work but prefered to reply rather than leaving this hanging. that's the kind of working interactions I like. Keep going this way. Thanks for the feedback. Bye, Mt. -- Avant d'installer linux, mon ordinateur plantait tout le temps, les filles me fuyaient, je n'avais pas d'amis ni de vie sociale, et j'avais des boutons. Maintenant, mon ordinateur ne plante plus.
signature.asc
Description: Digital signature
