Package: lvm2
Version: 2.02.104-2
Severity: important
Tags: patch

Hello Bastian,

You are currently patching the lvm2-lvmetad.service file to remove the
install section:

-[Install]
-WantedBy=sysinit.target

IMHO this would breaks the ordering if somebody wants to explicitly
enable the service.

You should probably use the --no-enable option of the dh_systemd_enable
helper.

Please considere applying the following patch.

Cheers,

Laurent Bigonville

-- System Information:
Debian Release: jessie/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.12-1-amd64 (SMP w/8 CPU cores)
Locale: LANG=fr_BE.utf8, LC_CTYPE=fr_BE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages lvm2 depends on:
ii  dmsetup                   2:1.02.83-2
ii  init-system-helpers       1.15
ii  initscripts               2.88dsf-51
ii  libc6                     2.17-97
ii  libdevmapper-event1.02.1  2:1.02.83-2
ii  libdevmapper1.02.1        2:1.02.83-2
ii  libreadline5              5.2+dfsg-2
ii  libudev1                  204-7
ii  lsb-base                  4.1+Debian12

lvm2 recommends no packages.

Versions of packages lvm2 suggests:
pn  thin-provisioning-tools  <none>

-- Configuration Files:
/etc/lvm/lvm.conf changed [not included]

-- no debconf information
diff -Nru lvm2-2.02.104/debian/patches/systemd.patch lvm2-2.02.104/debian/patches/systemd.patch
--- lvm2-2.02.104/debian/patches/systemd.patch	2014-02-10 22:49:31.000000000 +0100
+++ lvm2-2.02.104/debian/patches/systemd.patch	2014-02-15 11:48:03.000000000 +0100
@@ -45,12 +45,3 @@
 +
 +[Install]
 +WantedBy=local-fs.target
---- a/scripts/lvm2_lvmetad_systemd_red_hat.service.in
-+++ b/scripts/lvm2_lvmetad_systemd_red_hat.service.in
-@@ -14,6 +14,3 @@ ExecReload=@sbindir@/lvmetad -R
- Environment=SD_ACTIVATION=1
- Restart=on-abort
- PIDFile=@LVMETAD_PIDFILE@
--
--[Install]
--WantedBy=sysinit.target
diff -Nru lvm2-2.02.104/debian/rules lvm2-2.02.104/debian/rules
--- lvm2-2.02.104/debian/rules	2014-02-10 22:49:31.000000000 +0100
+++ lvm2-2.02.104/debian/rules	2014-02-15 11:50:10.000000000 +0100
@@ -239,7 +239,9 @@
 install_lvm2: DIR = $(BUILD_DIR)/install_deb
 install_lvm2: $(STAMPS_DIR)/install_deb
 	+$(MAKE_SELF) install-base-prep INSTALL_DIR='$(DIR)'
-	dh_systemd_enable
+	dh_systemd_enable -plvm2 lvm2-activation-early.service
+	dh_systemd_enable -plvm2 lvm2-activation.service
+	dh_systemd_enable -plvm2 --no-enable lvm2-lvmetad.service
 	dh_installinit --no-start -- start 26 S .
 	dh_systemd_start --no-start
 	+$(MAKE_SELF) install-base

Reply via email to