That's cool! I cannot think of any side effect either, short of
- that'll only work on POSIX systems (unsure if we care, but it'd
still be possible to fallback to STDIN on non-POSIX systems), and
- one would not longer be able to answer the questions with things like
‘yes | caff …’. (That wouldn't really make sense anyway, as there
are configuration options for that).
Also, rather than keeping opening/closing the TTY for each question
asked, an improvement would be to do it once and for all at the
beginning. One could even close STDIN and re-open it as /dev/tty; This
behavior can be emulated in a POSIX shell, and is one of the workaround
to the bad interaction between xargs and caff (or generally any program
proceeding its user interaction over STDIN):
xargs sh -c '</dev/tty caff "$@"' </path/to/fprs
I second that patch anyway ;-) If no one objects I'll merge the slight
modification outlined above.
Cheers,
--
Guilhem.
signature.asc
Description: Digital signature
