I think that's a great patch; I have added it here: http://maradns.samiam.org/download/patches/3rd_party/RandPrime.patch
And, for the record, my current policy is to not integrate third party patches unless they fix security or other critical bugs: http://samiam.org/blog/20120723.html "While I do appreciate third-party contributions to MaraDNS, I am the one who takes responsibility for any bugs a patch I accept introduces. I do not at present devote enough time to MaraDNS to be fixing bugs introduced by patches." As an update: MaraDNS now is in GitHub: https://github.com/samboy/MaraDNS - Sam On Wed, Feb 26, 2014 at 1:37 PM, Tobias Frost <[email protected]> wrote: > Hallo Sam, > > Well, I do not really like auto-generated stuff in a repository / > upstream source tarball ;-) .. > Also somehow a fixed random number somehow feels against the spirit of > randomness;-) > > So, may I propose #3? > Enhancing RandPrime.c to fall-back to stdlib's random() if there is > no /dev/urandom; I think this PRNG is better than a static random > number. (See attached patch) > > > -- > Tobias > > PS: you did not CC the Debian bug report; feel free to forward my > message to it if this was not intended.. > > > Am Mittwoch, den 26.02.2014, 10:09 -0800 schrieb Sam Trenholme: >> > - It always changes DwRandPrime.h and therefore changes the upstream >> > source outside of the debian directory, and deb-source barks. >> >> I would handle this problem in one of two ways: >> >> * I would change the Makefile to have "make clean" not nuke DwRandPrime.h > >> * The Git version of MaraDNS/Deadwood has a similar problem, since I >> can't include DwRandPrime.h in the Git tree (otherwise, it will change >> every time I do a "git commit -a -m '{description of change}'". The >> way I solved it there was to have the Windows Makefile in the Git tree >> just use a static random number for the hash compress core: >> >> https://github.com/samboy/MaraDNS/blob/master/deadwood-github/src/Makefile.mingw342 >> >> - Sam > -- To UNSUBSCRIBE, email to [email protected] with a subject of "unsubscribe". Trouble? Contact [email protected]
