Source: xnbd
Version: 0.3.0
Severity: normal
Dear Arno,
xnbd's get-orig-source assumes that REPOSITORY_REV is not empty which would,
however, be the case for normal releases. This causes the hg archive run to be
erroneously called with an "-r -t files".
An easy fix is to use something along the lines of:
--- snip ---
ifdef REPOSITORY_REV
HG_ARCHIVE_OPT := "-g $(REPOSITORY_REV)"
endif
....
get-orig-source:
# Version generated by: hg log -r . --template
'{latesttag}-hg{latesttagdistance}-{node|short}\n'
hg clone https://bitbucket.org/hirofuchi/xnbd xnbd-$(VERSION)-hg
cd xnbd-$(VERSION)-hg && hg archive -X .hg_archival.txt -X .hgtags
$(HG_ARCHIVE_OPT) -t files ../xnbd-$(VERSION)
....
--- snip ---
but there are, naturally, many ways to conditionally use the "-r
REPOSITORY_REV" if one is indeed trying to get hold of that version. It might
also be argued that one could simply export HEAD, but the aforementioned code
works for both hg snapshots and normal releases.
Merci
-- System Information:
Debian Release: jessie/sid
APT prefers testing
APT policy: (990, 'testing'), (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Kernel: Linux 3.12-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_GB.utf-8, LC_CTYPE=en_GB.utf-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
