Package: sniffit Version: 0.3.7.beta-17 Severity: minor Tags: patch Dear Maintainer,
Your package fails to build with clang instead of gcc. [-Wreturn-type] The attached patch fixes it. Buildlogs and patch are here: https://github.com/nonas/debian-clang/tree/master/buildlogs/sniffit Regards, Nicolas -- System Information: Debian Release: jessie/sid APT prefers testing-updates APT policy: (500, 'testing-updates'), (500, 'testing') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 3.12-1-amd64 (SMP w/4 CPU cores) Locale: LANG=en_US.utf8, LC_CTYPE=en_US.utf8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash
Description: Fix FTBFS with clang instead of gcc Author: Nicolas Sévelin-Radiguet <[email protected]> Last-Update: 2014-03-08 --- a/sniffit.0.3.7.c +++ b/sniffit.0.3.7.c @@ -1093,19 +1093,19 @@ finish = check_packet (ipaddr, p_header, sp, filename, filename2, &info, header, SNIFMODE); if (finish == DROP_PACKET) - return; /* Packet is broken */ + return 0; /* Packet is broken */ if( (PROTOCOLS&F_IP)&&((PROTOCOLS&F_TCP)==0)) memcpy (&iphead, (sp + PROTO_HEAD), sizeof (struct IP_header)), print_iphead (&iphead, 0); if (finish == DONT_EXAMINE) - return; /* Packet is not for us */ + return 0; /* Packet is not for us */ if(DUMPMODE==8) /* Recording */ { pcap_dump((unsigned char *) dev_dump, p_header, sp); - return; + return 1; } if((PROTOCOLS & F_IP)&&(PROTOCOLS & F_TCP)&&(finish<10)) @@ -1186,11 +1186,11 @@ if (status == 0) { if (finish == TCP_FINISH) - return; + return 1; /* there was never data transmitted */ /* seq_nr & datalen not important here yet */ if ((dummy_pointer = add_dynam (filename, TCP, 1, 0, 0)) == NULL) - return; + return 1; } f = dummy_pointer->f; @@ -1256,7 +1256,7 @@ printf ("\nYou mixed incompatible options!\n"); exit (1); } - return; + return 1; } if ((finish < 10) && (LOGPARAM != 0)) /* TCP packet - logfile */ @@ -1336,7 +1336,7 @@ break; } printf ("\n"); - return; + return 1; } if (finish < 30) /* nothing yet */ { @@ -1369,7 +1369,7 @@ printf ("\nImpossible error! Sniffer Hartattack!\n"); exit (0); } - return; + return 1; } } @@ -1482,9 +1482,9 @@ finish = check_mask (p_header, sp, conn_name, conn_name2, desc_string, &info); if (finish == DROP_PACKET) - return; /* Packet is broken */ + return 0; /* Packet is broken */ if (finish == DONT_EXAMINE) - return; /* Packet is not for us */ + return 0; /* Packet is not for us */ if (finish != TCP_FINISH) /* finish: already logged, or to short to add */ add_itemlist (running_connections, conn_name, desc_string); --- a/sn_analyse.c +++ b/sn_analyse.c @@ -10,7 +10,7 @@ { if(finish!=TCP_FINISH) if((dummy_pointer=add_dynam(filename, TCP, 0,ntohl(tcphead.seq_nr),info.DATA_len))==NULL) - return; + return 1; }; if(finish==TCP_FINISH) /* let's reset the connection */ @@ -26,7 +26,7 @@ if(dummy&SYN) print_conn(filename,"Connection initiated. (SYN)"); if(dummy&FIN) print_conn(filename,"Connection ending. (FIN)"); if(dummy&RST) print_conn(filename,"Connection reset. (RST)"); - return; + return 1; }; data = sp+PROTO_HEAD+info.IP_len+info.TCP_len; @@ -40,7 +40,7 @@ }; }; -if((dummy&FIN)||(dummy&RST)) return; /* needed, cauz entry don't exist */ +if((dummy&FIN)||(dummy&RST)) return 1; /* needed, cauz entry don't exist */ /*** TELNET *****************************************************************/ if(LOGPARAM & LOGPARAM_TELNET) @@ -197,5 +197,5 @@ if(ntohl(tcphead.seq_nr)>dummy_pointer->exp_seq) dummy_pointer->exp_seq=ntohl(tcphead.seq_nr)+info.DATA_len; } -return; -return; /* DON'T FORGET THEM!!!! */ +return 1; +return 1; /* DON'T FORGET THEM!!!! */
