On Wed, Mar 12, 2014 at 10:02:16AM -0400, Phillip Susi wrote: > On 3/12/2014 9:34 AM, Colin Watson wrote: > > I think it would be very helpful to split up the logical chunks of > > this. > > > > Moving ext2 support means that we need to make sure that > > partman-basicfilesystems and partman-ext3 land in unstable and > > testing at the same time, and derived distributions need to do that > > too. Given the general lack of tool support for this sort of > > lockstep change in udebs, I'm uncomfortable with bundling it into > > this change. Was there a good reason for that or did you just > > think it was tidier? If the latter, I think it would in fact be > > better avoided. > > The purpose of the patch is to stop depending on libparted. The > existing ext2 support thus needed removed and transitioned to the code > that is currently in partman-ext3. I suppose I could have copied and > pasted that code into partman-basicfilesystems, but needlessly > duplicating code seemed silly.
Please do it anyway - moving this around is going to be a pain. > > I think it would be a good idea to keep the sync call in place, at > > least in the event that mkfs succeeds. > > What for? If the system crashes 3 seconds later, who cares if the > disk was properly formatted or not? In the past there've been some problems with things like udev not picking changes up properly, I think. Memory is fuzzy. In any event, my point is that you should be decoupling things from the parted 3 transition when at all possible. We can always try removing syncs later; if it's done separately it will be easier to see when problems are down to that, rather than a giant debugging nightmare. > >> -Template: partman-basicfilesystems/text/noatime -Type: text -# > >> :sl2: -# Note to translators: Please keep your translations of > >> this string below -# a 65 columns limit (which means 65 > >> characters in single-byte languages) -_Description: noatime - do > >> not update inode access times at each access > > > > Even aside from my comments about moving ext2 support, you must > > not remove all these mount option templates. select_mountoptions > > always picks up the templates from > > partman-basicfilesystems/text/$op, and these mount options are made > > available for various different file systems. > > It looks to me like these templates were duplicated in > basicfilesystems and -ext3 because both ext2 and ext[34] needed them. > With ext2 removed from basicfilesystems, they seem to be unreferenced > cruft now. If the system always looks for them in -basicfilesystems, > then why are they duplicated in -ext3? I'm pretty sure I checked the > menu and they still showed up properly. There's no "noatime" template in -ext3, so I don't know what you're talking about here. Please just put these templates back; they are absolutely *not* unreferenced cruft. Cheers, -- Colin Watson [cjwat...@debian.org] -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org