Hi,

Silvio Rhatto wrote (18 Mar 2014 00:17:11 GMT) :
> Em Mon, Mar 17, 2014 at 10:29:12AM +0100, intrigeri escreveu:
>> Great! Here's a quick code review of the changes since 0.2.9.

> Thanks for the review :)

You're welcome. In the future, how about releasing a RC, issueing
a call for reviews and tests, before going the full way to RFS?

Congrats for the improvements. Only two minor glitches remain.

I can now see:

> -      echo "Fatal: no such key $recipient on your GPG keyring."
> +      echo "Fatal: no such key $recipient on your OpenPGP keyring."

... but I'm not sure "OpenPGP keyring" makes any sense. Unless the
OpenPGP standard defines this concept, I think "GnuPG keyring" would
be more correct.

>> > +        gpg --batch --refresh-keys "$recipient"
>> 
>> I'm not sure this really does what you mean here. At least the GnuPG
>> manpage does not talk about it. Perhaps use --recv-keys for
>> better clarity?

Ping?

Cheers,
-- 
  intrigeri
  | GnuPG key @ https://gaffer.ptitcanardnoir.org/intrigeri/intrigeri.asc
  | OTR fingerprint @ https://gaffer.ptitcanardnoir.org/intrigeri/otr.asc


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to