Source: stgit
Version: 0.17.1-1
Severity: normal
User: [email protected]
Usertags: autopkgtest
Tags: patch

The purpose of DEP-8 tests is to test the *installed* package, and the
tests included with stgit are not doing this.

The attached patch works for me. Just running `cd t && python test.py`
will not work as somehow test.py will still use the code from the source
tree.

You will probably want to forward the change to t/test.py to upstream.

-- System Information:
Debian Release: jessie/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 3.13-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=pt_BR.UTF-8, LC_CTYPE=pt_BR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

-- 
Antonio Terceiro <[email protected]>
diff -ru stgit-0.17.1.orig/debian/tests/control stgit-0.17.1/debian/tests/control
--- stgit-0.17.1.orig/debian/tests/control	2014-03-29 18:20:51.719038195 -0300
+++ stgit-0.17.1/debian/tests/control	2014-03-29 18:23:45.839092820 -0300
@@ -1,3 +1,3 @@
 Tests: testsuite
-Depends: @, @builddeps@
-Restrictions: build-needed allow-stderr
+Depends: @
+Restrictions: allow-stderr
diff -ru stgit-0.17.1.orig/debian/tests/testsuite stgit-0.17.1/debian/tests/testsuite
--- stgit-0.17.1.orig/debian/tests/testsuite	2014-03-29 18:20:51.719038195 -0300
+++ stgit-0.17.1/debian/tests/testsuite	2014-03-29 18:24:24.963099269 -0300
@@ -1,3 +1,5 @@
 #!/bin/sh
 
-dh_auto_test
+cp -r t/ $ADTTMP
+cd $ADTTMP/t
+python test.py
diff -ru stgit-0.17.1.orig/t/test.py stgit-0.17.1/t/test.py
--- stgit-0.17.1.orig/t/test.py	2014-03-29 18:20:52.619038588 -0300
+++ stgit-0.17.1/t/test.py	2014-03-29 18:32:13.431019395 -0300
@@ -175,6 +175,7 @@
         for t in sorted(failed):
             print "  ", t
         print "Done"
+        exit(1)
 
 if __name__ == "__main__":
     main()

Attachment: signature.asc
Description: Digital signature

Reply via email to