control: tags -1 + pending upstream
control: tags -1 - patch
thanks

Hi Alkis,

On Mittwoch, 20. Februar 2013, Alkis Georgopoulos wrote:
> Στις 20/02/2013 10:33 πμ, ο/η Holger Levsen έγραψε:
> > I hope these are indeed only commits touching the greek translation.

sorry for the delay in getting back to you and your patch. I've now rebased 
and merged it into the git master branch, so that greek support will be 
available in the next release (1.8.3).
 
> There's only one commit not directly related to the Greek translation,
> the one that says "Align letters more accurately on the keyboard."

I've attached this patch to this mail, so other people for knowledgable with 
the code can comment on this.

> That changes 1 number in alphabet.c, otherwise the Greek letters overlap
> in the displayed keyboard, so in reality it'd consider it a part of the
> translation effort as well. :)

but it changes it for all languages, doesnt it? Have you tested other 
languages with that patch?

> > If you could provide it as a git branch, that would be much preferred.
> 
> My first try in both git and github, I hope I got it right:
> https://github.com/alkisg/tuxtype/commits/

looked very well!

> I left the alphabet.c change last in case you want to omit it.

for now, yes.

> I cleaned up the commits a lot, so please completely ignore the previous
> bazaar branch I sent.

well done, thanks!


cheers,
        Holger


From d5461d5c1adaac5660068208e3f486c3f73a6f2c Mon Sep 17 00:00:00 2001
From: Alkis Georgopoulos <[email protected]>
Date: Wed, 20 Feb 2013 13:34:56 +0200
Subject: [PATCH] Align letters more accurately on the keyboard.

---
 src/alphabet.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/alphabet.c b/src/alphabet.c
index a6ddbd7..18fc7ad 100644
--- a/src/alphabet.c
+++ b/src/alphabet.c
@@ -1236,7 +1236,7 @@ void GenerateKeyboard(SDL_Surface* keyboard)
     if(!render)
       continue;
 
-    new.x += (31 * col);
+    new.x += (int)(30.5 * col);
 
     if(keyboard_list[i].shift > 0)
     {
-- 
1.8.5.3

Attachment: signature.asc
Description: This is a digitally signed message part.

Reply via email to