Package: xgammon
Version: 0.99.1128-3
Severity: wishlist
Usertags: goto-cc

During an analysis of all packages using our research compiler tool-chain (using
tools from the cbmc package) the following error was found:

The declaration of CompiFinish in src/xgammon.c

http://sources.debian.net/src/xgammon/0.99.1128-3/src/xgammon.c?hl=117#L117

shadows the fact that CompiFinish actually requires 4 arguments:

http://sources.debian.net/src/xgammon/0.99.1128-3/src/xgammon.c?hl=1294#L1294

Yet none is provided with the call in MenuSelect:

http://sources.debian.net/src/xgammon/0.99.1128-3/src/xgammon.c?hl=1097#L1097

As, however, the argument aren't used code might execute correctly at present.
To avoid the risk of undefined behaviour the definition of CompiFinish should be
fixed.

Best,
Michael

Attachment: pgppE4ggwctto.pgp
Description: PGP signature

Reply via email to