Package: gupnp-tools
Version: 0.8.9-1
Usertags: goto-cc

During a rebuild of all Debian packages in a clean sid chroot (using cowbuilder
and pbuilder) the build failed with the following error. Please note that we
use our research compiler tool-chain (using tools from the cbmc package), which
permits extended reporting on type inconsistencies at link time.

[...]
libtool: link: gcc -pthread -I/usr/include/libsoup-2.4 -I/usr/include/libxml2 
-I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include 
-I/usr/include/uuid -I/usr/include/gupnp-1.0 -I/usr/include/gssdp-1.0 -pthread 
-I/usr/include/libsoup-2.4 -I/usr/include/libxml2 -I/usr/include/glib-2.0 
-I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/uuid 
-I/usr/include/gupnp-av-1.0 -I/usr/include/gupnp-1.0 -I/usr/include/gssdp-1.0 
-pthread -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include 
-I../.. -I../../src/common -g -O2 -fstack-protector --param=ssp-buffer-size=4 
-Wformat -Werror=format-security -Wall -Wl,-z -Wl,relro -Wl,--as-needed -o 
gupnp-upload main.o control_point.o item-creation.o container-search.o 
transfer.o -Wl,--export-dynamic  -lgupnp-1.0 -lgssdp-1.0 -lgupnp-av-1.0 
-lgio-2.0 -lgobject-2.0 -lglib-2.0 -pthread

error: conflicting function declarations "create_item"
old definition in module main file item-creation.h line 27
void (const char *, const char *, struct _GUPnPServiceProxy *, const char *, 
struct _GUPnPContext *)
new definition in module item-creation file item-creation.c line 227
void (const char *file_path, const char *title, struct _GUPnPServiceProxy 
*cds_proxy, const char *container_id)
Makefile:458: recipe for target 'gupnp-upload' failed
make[4]: *** [gupnp-upload] Error 64

Note that the declaration in item-creation.h lacks the 5th parameter
(container_id). Reviewing the code, it is not only the declaration that lacks
this, but so do all calls to create_item. Hence stack underflow will occur, and
undefined behaviour will result (the pointer will take an arbitrary value).

Best,
Michael

Attachment: pgpDSafOEIRhe.pgp
Description: PGP signature

Reply via email to