Osamu Aoki <[email protected]> writes: > On Sun, Jun 22, 2014 at 07:38:23PM +0530, Vasudev Kamath wrote: >> > I also copy tar in dist.py to the root of the source tree to keep >> > package-1.0/ and package.tar.gz in the same location. >> >> Probably better to move it to sanity.py to do it right? > > No it does not work. -d (dist.py) generates tarball from upstream VCS > using upstream ethod such as "make dist". So tarball exists only after > sanity.py run.
Ah yeah that is different use case so fine your new patch looks fine for me. > > As for your question of PEP-8, I assume you are talking long lines. Yep. that is first thing I noticed but haven't really ran pep-8 on entire source though. > > debug lines are long to make it easy to scan source to check such lines > by grep. Others, you can call me lazy. I keep terminal width > relatively large like 100. I will happy to fold 80 if they are not > debug lines. I see, I normally keep everything under pep8 in my python project as its the standard accepted by python community (ofcourse now screen supports more than 80 column but we still carry baggage from past happily) Cheers, -- Vasudev Kamath http://copyninja.info Connect on ~friendica: [email protected] IRC nick: copyninja | vasudev {irc.oftc.net | irc.freenode.net} GPG Key: C517 C25D E408 759D 98A4 C96B 6C8F 74AE 8770 0B7E
signature.asc
Description: PGP signature
