Hello all,

Michael Biebl [2014-06-25  9:01 +0200]:
> This was one of the patches you merged over from Ubuntu and it seems
> that loading the sg module does break luks+crypt.
> 
> Do you remember why that patch was needed in the first place?

No, it didn't come from Ubuntu, but this has been a Debian specific
udev rule for years. It came from https://bugs.debian.org/657948 to
support tape drives with sd and sg built as modules, as done by the
Debian kernel. (FTR, Ubuntu's kernel has both built in and doesn't
need any of this).

E. g. in wheezy the rule looked like

  SUBSYSTEM=="scsi", ENV{DEVTYPE}=="scsi_device", TEST!="[module/sg]", 
RUN+="/sbin/modprobe -b sg"

So the main change was that we now use the kmod builtin instead of
calling modprobe. The latter is much slower, and thus I suppose this
delayed sg long enough for the sd module to actually detect and "grab"
the SCSI disks. From that POV it's rather curious that this never led
to boot problems before (or at least not up to the point where people
filed bugs).

So I propose for now to go back to modprobe. It's a disaster waiting
to happen, but apparently it has worked for many years so let's go
back to a known-working state. I'll do that change in git now.

Thanks, and sorry for the trouble! (Yay race conditions)

Martin
-- 
Martin Pitt                        | http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)

Attachment: signature.asc
Description: Digital signature

Reply via email to