On 07/01/2014 11:38 AM, Bill Allombert wrote:
On Tue, Jul 01, 2014 at 10:58:17AM -0300, Mauricio Faria de Oliveira wrote:
Clearly, the original files were generated without patching.

Agreed. I would think it might have happened when ansi2knr was not
yet deprecated, or a local option was used in a Makefile.am, maybe
both.. maybe none. :)

According to the embedded comments, the files were generated by 1.11.1.

Ok, so that matches the first option; de-ANSI-fication was deprecated
slightly afterwards, in automake 1.11.*2*:

        "[...] this change should end up into 1.11.2," [1]

        $ fgrep de-ANSI-fication automake-1.11.*/NEWS
        automake-1.11.1/NEWS:* Automatic de-ANSI-fication cleaned up.
automake-1.11.2/NEWS: - The Automake support for automatic de-ANSI-fication will be removed in
        automake-1.11.2/NEWS:* Automatic de-ANSI-fication cleaned up.


If I got you right, the inconvenience itself seems to be carrying
a patch only for that matter, if an env var/cmdline arg could do.
So, for that, I wouldn't know another option.

Would that be OK with the rationale above?

I am concerned that, if we cannot rebuild the files from the upstream source
without patching, we cannot trust future versions of autoconf/automake to
process our patched code correctly.  This leads to a huge maintainance cost.

That's certainly understandable.  Nonetheless, I'd think the problem is
not tied to future versions only, but old ones too; 1.11.x seems old
already (2009/2012). Anything >= 1.11.2 would fail for de-ANSI-fication.

Interestingly, that thread also mentions libjpeg8c was affected, and
then 8*d* (next version) introduced -Wno-obsolete in configure.ac.

So I'd think they also chose to stick no -Wno-obsolete rather than
removing ansi2knr on libjpeg8; and then libjpeg*9* actually removed it.


Now, well, AFAICT there are not many options, since:
1) automake 1.11.x releases finished
2) automake 1.11.2+ only handle de-ANSI-fication with -Wno-obsolete
2) automake 1.12.x releases don't handle de-ANSI-fication
3) libjpeg6 releases finished

So autoreconf on libjpeg6 is tied to 1.11.x, and it would require
-Wno-obsolete (adopted on libjpeg8 from 8c to 8d).

Sure enough, I would be happy to provide a patch that only updates
the minimum required pieces for building on ppc64el, and not doing
autoreconf at all. (the other way around :)

What is your take on that?

Thanks!


[1] http://lists.gnu.org/archive/html/automake/2011-06/msg00007.html

--
Mauricio Faria de Oliveira
IBM Linux Technology Center


--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to