Package: ifupdown-extra
Version: 0.25
Severity: normal
Tags: patch

The line in check_status_ethtool():
 local LINK=$($ETHTOOL "$IFACE" 2>&1 | grep "Link detected" || :)
fails because ethtool has leading spaces.
A simple fix is to quote:
  local LINK="$($ETHTOOL "$IFACE" 2>&1 | grep "Link detected" || :)"
---------------------------------------------------------------------

--System Information:
Debian Release: jessie/sid
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 3.14-2-amd64 (SMP w/8 CPU cores)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages ifupdown-extra depends on:
ii  bind9-host [host]            1:9.9.5.dfsg-4
ii  curl                         7.37.1-1
ii  dpkg                         1.17.10
ii  host                         1:9.9.5.dfsg-4
ii  iproute2                     3.16.0-1
ii  iputils-arping               3:20121221-5+b1
ii  iputils-ping [ping]          3:20121221-5+b1
ii  net-tools                    1.60-26
ii  netcat-traditional [netcat]  1.10-40

Versions of packages ifupdown-extra recommends:
ii  ethtool  1:3.13-1

ifupdown-extra suggests no packages.

-- no debconf information
--- 00check-network-cable_old	2014-04-10 00:38:10.000000000 +0100
+++ 00check-network-cable_new	2014-08-21 14:48:47.998575266 +0100
@@ -69,7 +69,7 @@
 
 check_status_ethtool() {
 	local status=0
-	local LINK=$($ETHTOOL "$IFACE" 2>&1 | grep "Link detected" || :)
+	local LINK="$($ETHTOOL "$IFACE" 2>&1 | grep "Link detected" || :)"
 
 	# If ethtool fails to print out the link line we break off
 	# notice that ethtool cannot get the link status out of all
--- 00check-network-cable_old	2014-04-10 00:38:10.000000000 +0100
+++ 00check-network-cable_new	2014-08-21 14:48:47.998575266 +0100
@@ -69,7 +69,7 @@
 
 check_status_ethtool() {
 	local status=0
-	local LINK=$($ETHTOOL "$IFACE" 2>&1 | grep "Link detected" || :)
+	local LINK="$($ETHTOOL "$IFACE" 2>&1 | grep "Link detected" || :)"
 
 	# If ethtool fails to print out the link line we break off
 	# notice that ethtool cannot get the link status out of all

Reply via email to