Hi Michael,
I tried to address the issues you mentioned - the new package is in mentors.
<http://mentors.debian.net/package/pycountry>
> 1. The debian revision version number must reflect the NMU, i.e.
> should be -0.1, not -1
Fixed, my apologies for this silly error.
> 2. The distribution must be "unstable", not "unreleased"
Fixed, my apologies for this silly error.
> 3. The package fails to build for me, it apparently required
> python3-setuptools (which would be consistent with the other python
> package Build-Depends):
Fixed, there was also `unzip`, which I missed. Thanks!
> 4. The package in unstable got repackaged (+ds1 upstream version number)
> to remove a duplicated copy of isocodes, according to README.source. The
> new package does not have that, either the upstream version number shold
> be amended to reflect that, or README.source should get
> removed/adjusted
Not sure what you mean here.
In [0] I see that src/pycountry/{databases,locales} are still
there, so the target get-orig-source in debian/rules might be still
needed. I've updated it to deal with new package versions. Hope that's
fine.
> 5. 02-support_language_common-name.patch got removed, that should be
> mentioned in the changelog
Fixed, my apologies for this silly error.
> 6. There's a typo in the changelog: "Add .zip urls to wach",
> s/wach/watch
Fixed, my apologies for this silly error.
[0] <https://pypi.python.org/packages/source/p/pycountry/pycountry-1.8.zip>
Thank you for reviewing,
--
m.
--
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]
