Rodrigo Campos, 2014-08-26 01:55+0100:
On Mon, Aug 25, 2014 at 05:51:52PM +0200, Tanguy Ortolo wrote:Given the importance of this modification, and the level of damage it could do if we made a mistake (it deletes file in a wiki data directory!), I will upload this revision to experimental: could you please test it and confirm it does not delete production data? Only after that will I be able to upload it to unstable.Sure! I've just tried it and I can confirm it worked fine on my production system. Let me explain how I tried it, just in case: I installed the dokuwiki in my local PC, copied the cron file to my server (I've done a snapshot just before trying this, of course ;) and changed all default from false to true (so I try all the cases). Oh, and also commented the source to /etc/default/dokuwiki as that file does not exist on my installation from stable.
You could have copied /etc/default/dokuwiki that only exists for configuring the cron job!
Then run the script and everything went fine.
I didn't test changing the date of the files and verify they are deleted, but
that should work.
I've detected a very simple problem on my local machine, though. The line that
says:
find cache/?/ -type f -mtime "+$max_days" -delete
fails on a new dokuwiki installation. And it faile because the cache directory
is empty on a brand new installation. Just changing it to:
find cache -type f -mtime "+$max_days" -delete
works just fine (the "/?/" is not really important, as the filter for "-type f"
is there) because the cache directory is created during the installation.
Correct, I will apply the same.
If you want me to test something else, please let me know :)
That should be enough, I shall upload it to unstable soon. Thank you! -- ,--. : /` ) ن Tanguy Ortolo <xmpp:tan...@ortolo.eu> | `-' Debian Developer <irc://irc.oftc.net/Tanguy> \_
signature.asc
Description: Digital signature
