> From: Tobias Frost <t...@frost.de> To: Gianfranco Costamagna <costamagnagianfra...@yahoo.it> Cc: Vincent Cheng <vch...@debian.org>, "752...@bugs.debian.org" <752...@bugs.debian.org>, "ma...@debian.org" <ma...@debian.org> Date: Fri, 29 Aug 2014 08:06:32 +0200 In-Reply-To: <1409216214.5018.yahoomail...@web171801.mail.ir2.yahoo.com> References: <1409081409.6673.13.ca...@edoras.loewenhoehle.ip> <caczd_tbmfk3yatdgdiwqnrspshi8gx1jsh3w-ijhmw9cmyj...@mail.gmail.com> <9e5e4697519ad275d1b21932f44f616a.squir...@isengard.linuxd.net> <1409140568.30766.yahoomail...@web171806.mail.ir2.yahoo.com> <1409216214.5018.yahoomail...@web171801.mail.ir2.yahoo.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.12.2-1+b1 Mime-Version: 1.0
Hi Gianfranco, I will complete the review this evening / latest tomorrow and (if not f On Thu, 2014-08-28 at 09:56 +0100, Gianfranco Costamagna wrote: > Hi again,=20 > this is the updated proposed debdiff > diff -Nru lucene++-3.0.6/debian/changelog lucene++-3.0.6/debian/changelog > --- lucene++-3.0.6/debian/changelog 2014-08-26 12:49:11.000000000 +020= 0 > +++ lucene++-3.0.6/debian/changelog 2014-08-27 13:51:33.000000000 +020= 0 > @@ -1,10 +1,3 @@ > -lucene++ (3.0.6-2) unstable; urgency=3Dmedium > - > - * Update copyright file. > - * move doxygen to Build-Depends-Indep. > - > - -- Gianfranco Costamagna <costamagnagianfra...@yahoo.it> Tue, 26 Aug 2= 014 11:36:24 +0200 > - > lucene++ (3.0.6-1) unstable; urgency=3Dlow > =20 > * Initial release (Closes: #750148). > diff -Nru lucene++-3.0.6/debian/liblucene++-doc.install lucene++-3.0.6/de= bian/liblucene++-doc.install > --- lucene++-3.0.6/debian/liblucene++-doc.install 2014-07-02 17:38:53.= 000000000 +0200 > +++ lucene++-3.0.6/debian/liblucene++-doc.install 1970-01-01 01:00:00.= 000000000 +0100 > @@ -1 +0,0 @@ > -usr/share/doc/lucene++-3.0.6/* usr/share/doc/liblucene++-doc/html > diff -Nru lucene++-3.0.6/debian/rules lucene++-3.0.6/debian/rules > --- lucene++-3.0.6/debian/rules 2014-07-04 13:16:51.000000000 +0200 > +++ lucene++-3.0.6/debian/rules 2014-08-28 10:10:31.000000000 +0200 > @@ -1,5 +1,4 @@ > #!/usr/bin/make -f > -# -*- makefile -*- > =20 > # Uncomment this to turn on verbose mode. > #export DH_VERBOSE=3D1 > @@ -8,7 +7,12 @@ > dh $@ --with linktree -- --parallel --fail-missing > =20 > override_dh_auto_configure: > - dh_auto_configure -- -DENABLE_DOCS:BOOL=3DON -DENABLE_STANDARD_ALLOC= ATOR:BOOL=3DON > + dh_auto_configure -- -DENABLE_STANDARD_ALLOCATOR:BOOL=3DON > =20 > -override_dh_auto_build: > +override_dh_auto_build-indep: > + dh_auto_configure -- -DENABLE_STANDARD_ALLOCATOR:BOOL=3DON -DENABLE_= DOCS:BOOL=3DON > dh_auto_build -- doc > + > +override_dh_install-indep: > + dh_install -pliblucene++-doc usr/share/doc/lucene++-3.0.6/* usr/shar= e/doc/liblucene++-doc/html > + rm -rf debian/tmp/usr/share/doc/lucene++-3.0.6/ >=20 the patch looks good, thanks. Also it builds :) >=20 > the rm seems needed, otherwise the --fail-missing will complain :) >=20 > @Tobias, for the VCS fields, I know they are 404 now, they will be create= d as soon as the package is uploaded, with the correct package >=20 > they will be really similar to this one > https://code.launchpad.net/~ubuntu-unity/lucene++/ubuntu >=20 > so in my opinion we should keep them without changing anything :) Regarding the VCS-*: I prefer to have either a working CVS at the point of upload (preferred) or the lines being removed in d/control and readded in an subsequent upload. Well, a VCS are also patient -- so why not immediately create it? (The only thing you need to delay until after uploading is the tagging, or more precise the push of the tag).=20 I do not require a specific CVS-layout, but I recommend not to only store the debian directory but also the source and having also in a upstea-branch and utilitzing pristine-tar (so basically what git-buildpackage recommends). But as said, not required, I do not want to interfere with the workflows you are used to. --=20 tobi -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org