Source: appstream Version: 0.7.0-2 Severity: minor Tags: patch User: [email protected] Usertags: clang-ftbfs
Dear Maintainer, Your package fails to build with clang instead of gcc. [-Wreturn-type] The attached patch fixes it. Buildlogs and patch are here: https://github.com/nonas/debian-clang/tree/master/buildlogs/appstream Regards, Nicolas -- System Information: Debian Release: jessie/sid APT prefers testing-updates APT policy: (500, 'testing-updates'), (500, 'testing') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 3.14-2-amd64 (SMP w/4 CPU cores) Locale: LANG=en_US.utf8, LC_CTYPE=en_US.utf8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash
Description: fix FTBFS with clang [-Wreturn-type] Author: Nicolas Sévelin-Radiguet <[email protected]> Last-Update: 2014-09-06 --- a/src/as-metadata.c +++ b/src/as-metadata.c @@ -319,7 +319,7 @@ gchar *content; gchar *node_name; GString *str; - g_return_if_fail (metad != NULL); + g_return_val_if_fail (metad != NULL, NULL); str = g_string_new (""); for (iter = node->children; iter != NULL; iter = iter->next) { --- a/src/as-component.c +++ b/src/as-component.c @@ -379,7 +379,7 @@ GHashTable* as_component_get_urls (AsComponent *self) { - g_return_if_fail (self != NULL); + g_return_val_if_fail (self != NULL, NULL); return self->priv->urls; } @@ -397,7 +397,7 @@ const gchar * as_component_get_url (AsComponent *self, AsUrlKind url_kind) { - g_return_if_fail (self != NULL); + g_return_val_if_fail (self != NULL, NULL); return g_hash_table_lookup (self->priv->urls, as_url_kind_to_string (url_kind)); }
