Hi! On Fri, 2014-09-05 at 16:01:30 -0400, Daniel Kahn Gillmor wrote: > On Thu 2014-08-28 11:47:17 -0400, Daniel Kahn Gillmor wrote: > > On 08/27/2014 11:06 AM, Guillem Jover wrote: > >> Ah, hmmm, yeah make sense. It also does really make sense as an > >> additional file alongside the others referenced from the .dsc > >> metadata. As a minor detail, the .asc would not be included in the > >> .changes file when the orig.tar is not included either in the upload. > > > > sure, that makes sense. > > > >> I'm thinking dpkg-source would automatically include it if it finds it > >> side by side the orig.tar. > > > > I like that. > > > >> But I'm not comfortable just adding it as is, > >> I'd probably want to bump the minor version of the format. As this gets > >> us to the problem that we currently conflate the .dsc file format version > >> with the actual source format version. > > > > I think you're saying you'd bump the minor version of the .dsc format, > > Is this something that can be done for dpkg before the jessie freeze?
Yeah, that was my plan. I've just been thinking how to best introduce it. > I don't think we need dpkg to actually do the file verification steps or > warnings or anything -- just accepting the .asc without complaint would > be clear the path for the rest of the archive-related tools (apt, > sbuild, dak, etc) to head in that direction. Given that there might be more software checking for the actual Format field value, than doing exhaustive checks on the contents of the Files field, it probably makes sense to just accept the .asc file there and be done with it, w/o any other change. I'm thinking, that because at least dpkg-source will break badly if such source packages are around, it might also make sense to just change dpkg-source to accept such .dsc files, but not build them for now (jessie), because I could see issues with it picking up the .asc file automatically and breaking stuff. And add full support in jessie+1. Probably adding a new Source-Features field, as you hinted at, might make more sense than changing the Format field, indeed. Have you checked how many packages do strict parsing of the Files fields in the .dsc file? I think the list at the bottom of <https://wiki.debian.org/Projects/DebSrc3.0> might be a good starting point, although it might miss newer stuff. (I should probably move that part into something like <https://wiki.debian.org/Teams/Dpkg/DebSupport>, but with DscSupport.) In any case, once I've slept a bit more over this, I'll send a mail to d-d about this and about git formatted patches which both relate to the source format. Thanks, Guillem -- To UNSUBSCRIBE, email to [email protected] with a subject of "unsubscribe". Trouble? Contact [email protected]
