On Thu, 11 Sep 2014, Guido Günther wrote: > > 2/ "gbp pq switch" should automatically call "gbp pq import" if there is > > a pre-existing debian/patches/series. If I want to start a new empty > > patch queue branch, it should be a dedicated command (and it could be > > used here for the case where debian/patches/series doesn't > > exist). > > I mostly agree here but the case were the series doesn't import needs > some consideration. (e.g. if it's better to create branch by going > back in history like --time-machine does or fail upfront) and we need > to decide whether to rebase the pq branch automatically on switch too.
It's better to go back in history and inform the user of the need to rebase. That said I find --time-machine a rather ugly hack. Wouldn't it be better if "gbp pq export" exported the upstream commit on which the patch queue is known to apply and then reuse that identifier to find a proper commit in the history ? Automatic rebasing does not seem a good idea for "gbp pq switch" since you can already get that by doing "gbp pq rebase" which does an implicit switch first if it's needed... Cheers, -- Raphaël Hertzog ◈ Debian Developer Discover the Debian Administrator's Handbook: → http://debian-handbook.info/get/ -- To UNSUBSCRIBE, email to [email protected] with a subject of "unsubscribe". Trouble? Contact [email protected]
