tag 761346 upstream fixed-upstream patch
thanks
Hi,
On 09/13/2014 06:14 AM, Paul Wise wrote:
> With the process tree listed below and gdm having been upgraded,
> needrestart still suggests restarting gdm.service even though the
> default needrestart configuration blacklists gdm since restarting it can
> result in user data loss.
>
> I'm not sure what went wrong here, is it due to the .dpkg-new stuff?
exactly. The current regex blacklist only matches if one of the
process's library has been upgraded.
You might try the attached diff for needrestart's config file. With the
patch it should ignore the blacklisted binaries after dpkg has replaced
them.
Thanks & HTH,
Thomas
> root 1277 /usr/sbin/gdm3
> root 1836 \_ /usr/bin/Xorg :0 -novtswitch -background none -noreset -verbose
> 3 -logfile /dev/null -auth /var/run/gdm3/auth-for-Debian-gdm-a2O0Y7/database
> -seat seat0 -nolisten tcp vt7
> root 2200 \_ gdm-session-worker [pam/gdm-password]
> pabs 2214 \_ /bin/sh /usr/bin/gnome-session-classic
> pabs 2261 \_ /usr/bin/ssh-agent env TMPDIR=/tmp/user/1000
> /usr/bin/gpg-agent --daemon --sh
> --write-env-file=/home/pabs/.gnupg/gpg-agent-info-chianamo
> /usr/bin/dbus-launch --exit-with-session gnome-session-classic
> pabs 2262 \_ /usr/bin/gpg-agent --daemon --sh
> --write-env-file=/home/pabs/.gnupg/gpg-agent-info-chianamo
> /usr/bin/dbus-launch --exit-with-session gnome-session-classic
> pabs 2267 \_ gnome-session --session gnome-classic
> pabs 2301 \_ /usr/lib/gnome-settings-daemon/gnome-settings-daemon
> pabs 2368 \_ /usr/bin/gnome-shell
>
> -- Package-specific info:
> needrestart output:
> [Core] Using UI 'NeedRestart::UI::stdio'...
> [main] detected systemd
> [main] #1277 uses obsolete binary /usr/sbin/gdm3.dpkg-new
> [main] #1277 is not a child
> [main] #2200 uses obsolete binary /usr/lib/gdm3/gdm-session-worker.dpkg-new
> [main] #2200 is a child of #1277
> [main] #2267 uses non-existing
> /usr/lib/x86_64-linux-gnu/libpango-1.0.so.0.3600.6
> [main] #2267 is a child of #2214
> [main] #2301 uses non-existing
> /usr/lib/x86_64-linux-gnu/libpango-1.0.so.0.3600.6
> [main] #2301 is a child of #2267
> [main] #2368 uses non-existing
> /usr/lib/x86_64-linux-gnu/libgdm.so.1.0.0.dpkg-new
> [main] #2368 is a child of #2267
> [main] #1277 exe => /usr/sbin/gdm3.dpkg-new
> [main] #1277 is gdm.service
> [main] #2214 exe => /bin/dash
> [main] #2214 running /etc/needrestart/hook.d/10-dpkg
> [main] #2214 package: dash
> [main] #2214 running /etc/needrestart/hook.d/20-rpm
> [main] #2214 running /etc/needrestart/hook.d/90-none
> [main] #2267 exe => /usr/bin/gnome-session
> [main] #2267 running /etc/needrestart/hook.d/10-dpkg
> [main] #2267 package: gnome-session-bin
> [main] #2267 running /etc/needrestart/hook.d/20-rpm
> [main] #2267 running /etc/needrestart/hook.d/90-none
> [main] #2368 exe => /usr/bin/gnome-shell
> [main] #2368 running /etc/needrestart/hook.d/10-dpkg
> [main] #2368 package: gnome-shell
> [main] #2368 running /etc/needrestart/hook.d/20-rpm
> [main] #2368 running /etc/needrestart/hook.d/90-none
> [Kernel] Linux: kernel release 3.16-1-amd64, kernel version #1 SMP Debian
> 3.16.2-2 (2014-09-08)
> Failed to load NeedRestart::Kernel::kFreeBSD: [Kernel/kFreeBSD] Not running
> on GNU/kFreeBSD!
> [Kernel/Linux] /boot/vmlinuz-3.16-1-amd64 => 3.16-1-amd64
> ([email protected]) #1 SMP Debian 3.16.2-2 (2014-09-08)
> [3.16-1-amd64]*
> [Kernel/Linux] Expected kernel version: 3.16-1-amd64
> Running kernel seems to be up-to-date.
> Services to be restarted:
> systemctl restart gdm.service
>
> -- System Information:
> Debian Release: jessie/sid
> APT prefers testing
> APT policy: (900, 'testing'), (800, 'unstable'), (700, 'experimental')
> Architecture: amd64 (x86_64)
>
> Kernel: Linux 3.16-1-amd64 (SMP w/4 CPU cores)
> Locale: LANG=en_AU.UTF-8, LC_CTYPE=en_AU.UTF-8 (charmap=UTF-8)
> Shell: /bin/sh linked to /bin/dash
>
> Versions of packages needrestart depends on:
> ii dpkg 1.17.13
> ii libmodule-find-perl 0.12-1
> ii libmodule-scandeps-perl 1.14-1
> ii libproc-processtable-perl 0.50-2+b1
> ii libsort-naturally-perl 1.03-1
> ii libterm-progressbar-simple-perl 0.03-1
> ii perl 5.20.0-6
>
> needrestart recommends no packages.
>
> needrestart suggests no packages.
>
> -- no debconf information
>
--
:: WWW: http://fiasko-nw.net/~thomas/ ::
::: Jabber: xmpp:[email protected] :::
:: flickr: http://www.flickr.com/photos/laugufe/ ::
diff --git a/ex/needrestart.conf b/ex/needrestart.conf
index ba7f52a..25eba48 100644
--- a/ex/needrestart.conf
+++ b/ex/needrestart.conf
@@ -36,31 +36,31 @@
# Blacklist binaries (list of regex)
$nrconf{blacklist} = [
# ignore sudo (not a daemon)
- q(^/usr/bin/sudo$),
+ q(^/usr/bin/sudo(\.dpkg-new)?$),
# ignore DBus
- q(^/usr/bin/dbus-daemon$),
+ q(^/usr/bin/dbus-daemon(\.dpkg-new)?$),
# ignore DHCP clients
- q(^/sbin/(dhclient|dhcpcd5|pump|udhcpc)$),
+ q(^/sbin/(dhclient|dhcpcd5|pump|udhcpc)(\.dpkg-new)?$),
# ignore NetworkManager
- q(^/usr/sbin/NetworkManager$),
+ q(^/usr/sbin/NetworkManager(\.dpkg-new)?$),
# ignore PulseAudio
- q(^/usr/bin/pulseaudio$),
+ q(^/usr/bin/pulseaudio(\.dpkg-new)?$),
# ignore zfs-fuse
- q(^/sbin/zfs-fuse$),
+ q(^/sbin/zfs-fuse(\.dpkg-new)?$),
# ignore display managers
- q(^/usr/sbin/gdm3$),
- q(^/usr/bin/kdm$),
- q(^/usr/sbin/ldm$),
- q(^/usr/sbin/nodm$),
- q(^/usr/bin/wdm$),
- q(^/usr/bin/xdm$),
- q(^/usr/sbin/lightdm$),
+ q(^/usr/sbin/gdm3(\.dpkg-new)?$),
+ q(^/usr/bin/kdm(\.dpkg-new)?$),
+ q(^/usr/sbin/ldm(\.dpkg-new)?$),
+ q(^/usr/sbin/nodm(\.dpkg-new)?$),
+ q(^/usr/bin/wdm(\.dpkg-new)?$),
+ q(^/usr/bin/xdm(\.dpkg-new)?$),
+ q(^/usr/sbin/lightdm(\.dpkg-new)?$),
];
# Disable interpreter scanners.