Control: severity -1 serious # Justification: blocks the on-going wxpython3.0 transition
[NB: If you just mail [email protected], that doesn't get sent on to the submitter - I only saw your reply because I happened to check the BTS web interface. You can explicitly CC: [email protected] to send email to the submitter too.] On Mon, Sep 15, 2014 at 11:28:18AM +0800, Ying-Chun Liu (PaulLiu) wrote: > I need some help on this. > After running wx-migration-tools, I got a patch as attachment. I've already attached an nmudiff to this bug, in which I've addressed this issue: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=759044#12 That patch also turns off the wxdebug assertion checks which would avoid the issue reported in #760552. So please start from that patch rather than throwing away my work on this and then asking me how to fix problems I already sent you the fix for. > However, it doesn't simply transit to wxpy3.0 because I get the > following error messages when installing the packages: > > 設定 tribler (6.3.1+git20140902.9a5a2604-1) ... > File "/usr/share/tribler/Tribler/Main/Dialogs/SaveAs.py", line 241 > dlg = wx.DirDialog(None, "Please select a directory to save this > torrent", style=wx.0) > > ^ > SyntaxError: invalid syntax This is because the existing code is rather bogus: dlg = wx.DirDialog(None, "Please select a directory to save this torrent", style=wx.wx.DD_NEW_DIR_BUTTON) Note the double prefix: "wx.wx." - this happens to work, but isn't right - it should be just wx.DD_NEW_DIR_BUTTON. But this flag is deprecated and set to 0 in both 2.8 and 3.0, so it is best to just remove it entirely (that way you won't need to update the code when the flag gets removed, which will probably happen in wxPython 3.2). This is why the update script changes wx.DD_NEW_DIR_BUTTON to 0 for you (it's much easier to get it to replace such flags with a literal 0 than to get it to actually remove them from the code entirely). Cheers, Olly -- To UNSUBSCRIBE, email to [email protected] with a subject of "unsubscribe". Trouble? Contact [email protected]
