On Mon, Oct 06, 2014 at 01:29:41PM +0200, Svante Signell wrote: > Currently onak fails to build from source due to missing linkage of > libpthread in the db4 backend test. The previously successfully built > version is 0.4.2-1. The attached patch rules.patch fixes this problem.
Firstly this is a problem that would have existed in 0.4.2-1 - the more recent versions switch the build system to dh which is then running the upstream tests and catching the fact that although everything compiled fine the db4 backend is not functional on hurd. Secondly I don't feel that patching the debian/rules is the right way to fix this; that doesn't help anyone compiling upstream on Hurd directly themselves. The requirement for pthread is coming via the db5.3 library, so the autoconf checks for that probably need to be expanded to include picking up -lpthread when necessary. I don't really like the fact that I'm then expected to know that pulling in a library might then need me to check for pthreads when I'm not using them, but perhaps there are examples of suitable autoconf snippets to do this correctly and generically? J. -- If this isn't war, why is CNN massing on the border? This .sig brought to you by the letter R and the number 24 Product of the Republic of HuggieTag -- To UNSUBSCRIBE, email to [email protected] with a subject of "unsubscribe". Trouble? Contact [email protected]
