Control: tags 764076 - help moreinfo On 10/06/2014 03:38 PM, Jakub Wilk wrote: > * Daniel Kahn Gillmor <[email protected]>, 2014-10-06, 14:15: >> Any suggestions for how to get to the cause of this? > > Valgrind tells me: > > ==6528== Invalid write of size 4 > ==6528== at 0x804AC8F: args_main (xdotool.c:507) > ==6528== by 0x804A5A4: xdotool_main (xdotool.c:316) > ==6528== by 0x804A4BB: main (xdotool.c:287) > ==6528== Address 0x442b0bc is 0 bytes after a block of size 44 alloc'd > ==6528== at 0x40291CC: malloc (in > /usr/lib/valgrind/vgpreload_memcheck-x86-linux.so) > ==6528== by 0x40425D3: xdo_new_with_opened_display (in > /usr/lib/libxdo.so.3) > ==6528== by 0x4042913: xdo_new (in /usr/lib/libxdo.so.3) > ==6528== by 0x804AC11: args_main (xdotool.c:493) > ==6528== by 0x804A5A4: xdotool_main (xdotool.c:316) > ==6528== by 0x804A4BB: main (xdotool.c:287) > > The line that triggers this buffer overflow is: > > context.xdo->debug = context.debug; > > And indeed, the xdo_t structure has changed incompatibly: modmap and > keymap fields have been removed.
thanks, this makes it all clear to me now. sorry for the breakage.
I'll to the temporary fix of making an exact version match, and discuss
this with upstream for figuring out future improvements.
Regards,
--dkg
signature.asc
Description: OpenPGP digital signature
