control: tag -1 + patch
On Tue, Oct 07, 2014 at 08:15:37AM +0000, Mike Gabriel wrote:
> Hi Helge,
>
> On Mo 18 Aug 2014 22:52:31 CEST, Helge Deller wrote:
>
> >Package: freerdp
> >Version: 1.1.0~git20140809.1.b07a5c1+dfsg-3
> >Severity: bug
> >
> >freerdp fails to build on various platforms for the same reason,
> >that it tries to compile with arm-specifc compile options:
> >cc: error: unrecognized command line option '-mfpu=neon'
> >cc: error: unrecognized command line option '-mfloat-abi=softfp'
> >
> >All of this is triggered by a wrongly set WITH_NEON CMakefile setting.
> >
> >For logs see:
> >
> >for sparc:
> >https://buildd.debian.org/status/package.php?p=freerdp&suite=sid
> >
> >for arm64, hppa and x32:
> >http://buildd.debian-ports.org/status/package.php?p=freerdp&suite=sid
> >
> >I can give access to a hppa machine if needed...
> >
> >Helge
>
> I have pushed two patches [1,2] to freerdp.git [3] that hopefully
> fix the observed issues.
>
> I tested this on sparc and with the first of those patches [1],
> freerdp now builds, but fails in TestAlignment (no. 51).
>
> Unfortunately, I do not have arm64 or hppa test machines. Do you
> think you could pull freerdp.git (master branch) and do a test build
> for me?
>
This patch indeed works on arm64. The real problem though is that
MATCHES takes a regular expression, do "arm*" matches every
architectures which contain "ar", like "aarch64", "parisc" or "sparc".
The simple patch below is therefore enough to fix the build failure:
--- freerdp-1.1.0~git20140921.1.440916e+dfsg1/cmake/ConfigOptions.cmake
+++ freerdp-1.1.0~git20140921.1.440916e+dfsg1/cmake/ConfigOptions.cmake
@@ -6,7 +6,7 @@ elseif((CMAKE_SYSTEM_PROCESSOR MATCHES "
elseif((CMAKE_SYSTEM_PROCESSOR MATCHES "i386") AND (CMAKE_SIZEOF_VOID_P EQUAL
8) AND (APPLE))
# Mac is weird like that.
set(TARGET_ARCH "x64")
-elseif(CMAKE_SYSTEM_PROCESSOR MATCHES "arm*")
+elseif(CMAKE_SYSTEM_PROCESSOR MATCHES "arm.*")
set(TARGET_ARCH "ARM")
endif()
--
Aurelien Jarno GPG: 4096R/1DDD8C9B
aurel...@aurel32.net http://www.aurel32.net
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
