> I think that gracefully stopping nginx is a better default the forcibly > stopping the process.
I certainly don't - both cases have uses. Please do not force sysadmins to wait for end user behavior *by default*. When I want end users to be able to influence my reboot time I'll specify a specific command. The default should not be to extend reboot time defined by the activity of people external to the system and this is what you have done by converting to graceful shutdown by default. You've reduced the functionality of this patch and decreased the utility of init. Why are you attempting to optimize for reduced command count? Tyler On Oct 8, 2014, at 5:47 AM, Christos Trochalakis <yati...@ideopolis.gr> wrote: > On Wed, Sep 24, 2014 at 09:21:15AM -0700, Tyler Riddle wrote: >> Package: nginx-common >> Version: 1.6.2-1 >> Severity: wishlist >> Tags: patch >> >> Dear Maintainer, >> >> When clustering nginx behind a load balancer it is useful to take the listen >> socket offline while allowing connected clients to finish their requests >> with out error. The included patch allows for a graceful-shutdown command >> that >> makes this trivial. Both the graceful schedule and the original stop schedule >> can also be defined in /etc/default/nginx for end user customization. >> > > I think that gracefully stopping nginx is a better default the forcibly > stopping the process. So I changed the stop command to do exactly that, > and make the stop schedule configurable. That way we don't have to > introduce a new command at all. > > After your report, I took a closer look to the systemd service file that, > supposdly, did a graceful stop and discovered that was not the case, so > we fixed that regression as well. > > The relevant commits are: > > 8cbf89988 Fix systemd graceful stopping issue > ef90f5ebc initscript: gracefully stop nginx by default > > http://anonscm.debian.org/cgit/collab-maint/nginx.git/log/?h=graceful-stop > > I plan to merge this branch tomorrow, any comments are welcome!
signature.asc
Description: Message signed with OpenPGP using GPGMail
