Package: virt-manager Version: 1:1.0.1-2 Severity: normal Tags: upstream Tags: fixed-upstream Tags: patch X-Debbugs-Cc: [email protected]
Hi, virt-manager 1.0 ships support for flagging USB devices as removable (contributed by a Tails developer, because we do need this here). Unfortunately, a follow-up refactoring by an upstream contributor (commit eee5061a) broke this feature with a tiny typo, and on current sid I get: Error changing VM configuration: define_disk() got an unexpected keyword argument 'removeable' Fortunately, another upstream contributor fixed this trivial typo with commit eb5b26131 (by removing *one* char, s/removeable/removable/), that is part of the 1.1 upstream release. The attached patch (against current Vcs-Git) import the fixup commit from upstream as a quilt patch. I've tested on current sid that it does indeed fix the bug for me. It would be great to have this fixed in Jessie :) Have you plans to re-upload virt-manager in time for it to migrate before the freeze? If you prefer me to NMU with these changes, just say so. Cheers, -- intrigeri
>From 420703e8d921e8ea407a9e2d78c664d2b2618477 Mon Sep 17 00:00:00 2001 From: intrigeri <[email protected]> Date: Wed, 8 Oct 2014 17:04:48 +0000 Subject: [PATCH 1/2] fix-removable-drive-support.patch: new patch, cherry-picked from upstream. --- debian/patches/fix-removable-drive-support.patch | 19 +++++++++++++++++++ debian/patches/series | 1 + 2 files changed, 20 insertions(+) create mode 100644 debian/patches/fix-removable-drive-support.patch diff --git a/debian/patches/fix-removable-drive-support.patch b/debian/patches/fix-removable-drive-support.patch new file mode 100644 index 0000000..d826937 --- /dev/null +++ b/debian/patches/fix-removable-drive-support.patch @@ -0,0 +1,19 @@ +Author: Giuseppe Scrivano <[email protected]> +Date: Tue Jun 24 13:59:12 2014 +0200 +Bug: https://bugzilla.redhat.com/show_bug.cgi?id=1112629 +Origin: upstream, https://git.fedorahosted.org/cgit/virt-manager.git/commit/?id=eb5b2613110dfaa23626a16704d18df0dbba5086 +Description: details.py: fix typo s|removeable|removable| + +diff --git a/virtManager/details.py b/virtManager/details.py +index dd43259..d3826e5 100644 +--- a/virtManager/details.py ++++ b/virtManager/details.py +@@ -2166,7 +2166,7 @@ class vmmDetails(vmmGObjectUI): + kwargs["shareable"] = self.widget("disk-shareable").get_active() + + if self.edited(EDIT_DISK_REMOVABLE): +- kwargs["removeable"] = bool( ++ kwargs["removable"] = bool( + self.widget("disk-removable").get_active()) + + if self.edited(EDIT_DISK_CACHE): diff --git a/debian/patches/series b/debian/patches/series index b028b2a..4ff2c04 100644 --- a/debian/patches/series +++ b/debian/patches/series @@ -1,3 +1,4 @@ virtinst/fix-path-to-hvmloader.patch virtinst/Fix-patch-to-pygrub.patch Move-GConf-values-to-GSettings.patch +fix-removable-drive-support.patch -- 2.1.1
