On Sat, 11 Oct 2014 21:20:24 +0300, Niko Tyni wrote: > The tests in t/external/ make network connections to several sites over > the Internet during the build. If the initial connect fails, the tests > are skipped, so the package will still build without a network connection. > > This is a privacy violation and mentioned in the Debian Perl Group Policy, see > http://pkg-perl.alioth.debian.org/policy.html#test_suites
The point about the privacy violation is good, thanks. So far we've only cared if the build succeeds with and without internet ... > I think we've standardized on using the NETWORK_TESTING environment > variable for this though I can't find much documentation about it. I don't share your optimism about a standard :) % grep NETWORK_TESTING */debian/rules libtest-requiresinternet-perl/debian/rules: # make sure tests pass with and without NO_NETWORK_TESTING libtest-requiresinternet-perl/debian/rules: NO_NETWORK_TESTING=1 dh_auto_test But I'd love to see a standard environment variable. Quick check (and I'm sure the pattern misses other variants): % grep NET */debian/rules dh-make-perl/debian/rules: HOME=$(BUILDHOME) NO_NETWORK=1 dh_auto_test get-flash-videos/debian/rules:export NO_NETWORK=1 libbot-basicbot-pluggable-perl/debian/rules: #use CONNECTED_TO_NET=1 when the build host does have internet access. libbot-basicbot-pluggable-perl/debian/rules: CONNECTED_TO_NET=0 dh_auto_test libgeo-coder-googlev3-perl/debian/rules: NO_NETWORK=1 dh_auto_test libimap-admin-perl/debian/rules: NOINTERNET=1 dh_auto_test liblivejournal-perl/debian/rules: NO_NETWORK=1 dh_auto_test libmail-checkuser-perl/debian/rules: # DISABLED TESTS REQUIRING NETWORK ACCESS: libnet-freedb-perl/debian/rules: # set HAVE_INTERNET to 1 for manual builds libnet-freedb-perl/debian/rules: HAVE_INTERNET=0 dh_auto_test libnet-mac-vendor-perl/debian/rules: NO_NETWORK=1 dh_auto_test libnet-rawip-perl/debian/rules: NONETWORK=1 dh_auto_test libnet-whois-parser-perl/debian/rules: #use CONNECTED_TO_NET=1 when you have access to internet libnet-whois-parser-perl/debian/rules: CONNECTED_TO_NET=0 dh_auto_test libtest-requiresinternet-perl/debian/rules: # make sure tests pass with and without NO_NETWORK_TESTING libtest-requiresinternet-perl/debian/rules: NO_NETWORK_TESTING=1 dh_auto_test libxml-stream-perl/debian/rules: NO_NETWORK=1 dh_auto_test [Other tries show:] libmojolicious-plugin-cgi-perl/debian/rules: DEBIAN_BUILD=1 dh_auto_test libnet-arp-perl/debian/rules: DEBIAN_BUILD=1 dh_auto_test Cheers, gregor -- .''`. Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06 : :' : Debian GNU/Linux user, admin, and developer - http://www.debian.org/ `. `' Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe `- NP: Flying Pickets: Tracks Of My Tears
signature.asc
Description: Digital Signature